Merged
Conversation
Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
Emit an error when incompatible sanitizer are configured through command line options. Previously the last one configured prevailed and others were silently ignored. Additionally use a set to represent configured sanitizers, making it possible to enable multiple sanitizers at once. At least in principle, since currently all of them are considered to be incompatible with others.
It does the same thing as `Deref` now
The `Call` terminator only works with `FnDef` and `FnPtr` types. It happened to work with `Self` so far because it was always substituted with the real type before being used.
No one actually works with src/tools/librustdoc, it's almost empty.
This is required to avoid cycles when evaluating auto trait predicates.
This commit modifies the pretty printer and const eval in the MIR so that `destructure_const` (used in `pretty_print_const_value`) can handle enums with no variants (or types containing enums with no variants). Signed-off-by: David Wood <david@davidtw.co>
Make `need_type_info_err` more conservative Makes sure arg patterns we are going to suggest on are actually contained within the span of the obligation that caused the inference error (credit to @lcnr for suggesting this fix). There's a subtle trade-off regarding the handling of local patterns which I've left a comment about. Resolves rust-lang#72690
…nikic Diagnose use of incompatible sanitizers Emit an error when incompatible sanitizer are configured through command line options. Previously the last one configured prevailed and others were silently ignored. Additionally use a set to represent configured sanitizers, making it possible to enable multiple sanitizers at once. At least in principle, since currently all of them are considered to be incompatible with others.
…tthewjasper shim.rs: avoid creating `Call` terminators calling `Self` Also contains some cleanup and doc comment additions so I could make sense of the code. Fixes rust-lang#73109 Closes rust-lang#73175 r? @matthewjasper
…an-DPC Clean up E0668 explanation r? @Dylan-DPC
…an-DPC Clean up E0670 explanation r? @Dylan-DPC
…ark-Simulacrum Add src/librustdoc as an alias for src/tools/rustdoc No one actually works with src/tools/rustdoc, it's almost empty. Closes rust-lang#73439
…const-val-enum-no-variants, r=oli-obk pretty/mir: const value enums with no variants Fixes rust-lang#72181. This PR modifies the pretty printer and const eval in the MIR so that `destructure_const` (used in `pretty_print_const_value`) can handle enums with no variants (or types containing enums with no variants). I'm not convinced that this is the correct approach, folks more familiar with `destructure_const` would be able to say - happy to adjust the PR. Looking through `destructure_const` and the functions that it invokes, it didn't seem like it was written to handle zero-variant-enums - I assume that case is handled earlier in some way so `destructure_const` doesn't need to under normal circumstances. It didn't seem like it would be straightforward to make `destructure_const` handle this case in a first-class-feeling way (e.g. adding a `Variants::None` variant), so this PR makes some minimal changes to avoid ICEs.
Unify region variables when projecting associated types This is required to avoid cycles when evaluating auto trait predicates. Notably, this is required to be able add Chalk types to `CtxtInterners` for `cfg(parallel_compiler)`. r? @nikomatsakis
Use alloc::Layout in DroplessArena API
…ckler Update the doc for std::prelude to the correct behavior Fixes rust-lang#64686. One line change to ensure the docs are correct about the behavior of the compiler when inserting`std::prelude::v1`. I don't think examples are necessary but I can add some (especially those from the original issue) if needed.
Bump Rustfmt and RLS Fixes rust-lang#73406 Fixes rust-lang#73199 Fixes rust-lang#73407 Fixes rust-lang#73200 cc @calebcartwright @topecongiro r? @ghost Let's see what CI says first
Member
Author
|
@bors r+ p=10 rollup=never |
Collaborator
|
📌 Commit 3e40cca has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Member
Author
|
@bors treeclosed=9 I plan to open another rollup after this, will cancel this before I disappear, but if not feel free to cancel if an hour has passed |
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
|
📣 Toolstate changed by #73528! Tested on commit 033013c. 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 20, 2020
Tested on commit rust-lang/rust@033013c. Direct link to PR: <rust-lang/rust#73528> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok). 🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro). 🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro).
Member
Author
|
Onto the next batch! |
This was referenced Jun 20, 2020
Contributor
|
One of these PRs resulted in a win on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
try_finda little #71899 (Refactortry_finda little)need_type_info_errmore conservative #73027 (Makeneed_type_info_errmore conservative)Callterminators callingSelf#73359 (shim.rs: avoid creatingCallterminators callingSelf)Failed merges:
r? @ghost