Add peek and peek_from to UnixStream and UnixDatagram#73761
Add peek and peek_from to UnixStream and UnixDatagram#73761bors merged 1 commit intorust-lang:masterfrom rijenkii:master
peek and peek_from to UnixStream and UnixDatagram#73761Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
See also #69864 |
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This seems reasonable to me. It needs to be rebased (rather than back-merging from the latest rust-lang/rust), but otherwise, I think it'd be reasonable to merge this. |
|
Done, but what about the |
|
☔ The latest upstream changes (presumably #75979) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Just adding my vote of interest to see this get merged! I've had to roll my own extension trait for |
|
This looks great to me. Could someone on @rust-lang/libs review and merge, please? |
|
It looks like this needs a rebase, but I'll r? @KodrAus for libs team unstable API approval. Implementation looks good to me too (r=me or Josh on that). |
KodrAus
left a comment
There was a problem hiding this comment.
PR is 80% tests and docs? Looks good to me!
It looks like we've got a merge conflict to work through so once that's sorted I'll push it through.
|
I'll fix the conflicts in the next couple of days, a little bit busy rn |
|
Done, I think |
|
bors r=KodrAus |
|
gah again .. @bors r=KodrAus |
|
📌 Commit 64b8fd7 has been approved by |
|
☀️ Test successful - checks-actions, checks-azure |
dtolnay
left a comment
There was a problem hiding this comment.
Please open a tracking issue for the new unstable methods and send a PR updating these issue = "..." attributes with the tracking issue number.
|
Tracking issue opened, PR sent |
Add tracking issue for feature(unix_socket_peek) Feature was added in rust-lang#73761
Add tracking issue for feature(unix_socket_peek) Feature was added in rust-lang#73761
This is my first PR, so I'm sure I've done some things wrong.
This PR:
peekfunction toUnixStream;peekandpeek_fromtoUnixDatagram;UnixDatagram::recv_fromimplementation to a private functionrecv_from_flags, aspeek_fromuses the same code, just with different flags.I've taken the documentation from
TcpStreamandUdpStream, so it may or may not make sense (I'm bad with english words).Also, I'm not sure what I should write in the
unstableattribute, so I've made up the name and set the issue to "none".Closes #68565.