Closed
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
@bors rollup=iffy |
Contributor
Author
|
@bors r+ |
Collaborator
|
📌 Commit b78dd15 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Member
|
You should use |
Contributor
Author
|
Good tip, fixed in rust-lang/rust-analyzer#5340 |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 13, 2020
…=matklad ⬆️ rust-analyzer
Member
bors
added
S-waiting-on-author
Contributor
Author
|
Yup, legitimate failure, hopefully will be fixed next week. I am also going to add power check build to our CI — it’s the second time we fail with AtomicU64 error. I wish we had(transitive) portability lints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.