Rollup of 18 pull requests by Manishearth · Pull Request #74308 · rust-lang/rust

Manishearth · 2020-07-13T23:26:22Z

Successful merges:

Add Ayu theme to rustdoc #71237 (Add Ayu theme to rustdoc)
Substantial refactor to the design of LineWriter #72808 (Substantial refactor to the design of LineWriter)
Update RELEASES.md for 1.45.0 #73354 (Update RELEASES.md for 1.45.0)
rustdoc: insert newlines between attributes #73852 (rustdoc: insert newlines between attributes)
Document the union keyword #73867 (Document the union keyword)
add (unchecked) indexing methods to raw (and NonNull) slices #73986 (add (unchecked) indexing methods to raw (and NonNull) slices)
Fix caching issue when building tools. #74046 (Fix caching issue when building tools.)
clean up E0718 explanation #74123 (clean up E0718 explanation)
rustdoc: Allow linking from private items to private types #74147 (rustdoc: Allow linking from private items to private types)
Detect tuple struct incorrectly used as struct pat #74173 (Detect tuple struct incorrectly used as struct pat)
Remove an unwrap in layout computation #74227 (Remove an unwrap in layout computation)
Update llvm-project to latest origin/rustc/10.0-2020-05-05 commit #74239 (Update llvm-project to latest origin/rustc/10.0-2020-05-05 commit )
Teach bootstrap about target files vs target triples #74251 (Teach bootstrap about target files vs target triples)
don't mark linux kernel module targets as a unix environment #74257 (don't mark linux kernel module targets as a unix environment)
Slight reorganization of sys/(fast_)thread_local #74263 (Slight reorganization of sys/(fast_)thread_local)
typeck: report placeholder type error w/out span #74270 (typeck: report placeholder type error w/out span)
#71669: add ui, codegen tests for volatile + nearby int intrinsics #74285 (Missing tests for intrinsics. #71669: add ui, codegen tests for volatile + nearby int intrinsics)
Added detailed error code explanation for issue E0688 in Rust compiler. #74286 (Added detailed error code explanation for issue E0688 in Rust compiler.)

Failed merges:

This commit redesigns LineWriter to work more directly on the internals of BufWriter. This interface change is to enable a future Pull Request in which Stdout can be switched between Line and Block buffered mode.

- Added a bunch of new unit tests - Removed test_line_buffer_fail_flush - Updated erroneous_flush_retried - Added helper methods to LineWriterShim for code clarity, to distinguish "self.buffer" (the BufWriter) from self.inner (the thing wrapped by the BufWriter) - Un-expressionized write & write_all - Added clause to bail early on Ok(0)

- Cleaned up BufWriter::seek - Updated line_vectored test - Updated line_vectored_partial_and_errors test - Added several new tests

- Renamed write_to_buffer to write_to_buf, for consistency - Fixed references to flush_buf - Optimized `write` to use one less `memchr` call

- Fixed test after write_vectored bugfix - Some comments

@the8472

- Fixed partial-line buffering issue - Added tests Thanks @the8472 for catching!

Co-authored-by: Josh Triplett <josh@joshtriplett.org>

@joshtriplett

don't mark linux kernel module targets as a unix environment refs rust-lang#74247 r?@joshtriplett cc: @ehuss

…acrum Slight reorganization of sys/(fast_)thread_local I was long confused by the `thread_local` and `fast_thread_local` modules in the `sys(_common)` part of libstd. The names make it *sound* like `fast_thread_local` is just a faster version of `thread_local`, but really these are totally different APIs: one provides thread-local "keys", which are non-addressable pointer-sized pieces of local storage with an associated destructor; the other (the "fast" one) provides just a destructor. So I propose we rename `fast_thread_local` to `thread_local_dtor`, and `thread_local` to `thread_local_key`. That's what this PR does.

@estebank

…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank

rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics Added some tests for intrinsics. See rust-lang#71669.

@GuillaumeGomez

…Gomez Added detailed error code explanation for issue E0688 in Rust compiler. Added proper error explanation for issue E0688 in the Rust compiler. Error Code E0688 Sub Part of Issue rust-lang#61137 r? @GuillaumeGomez

Manishearth · 2020-07-13T23:26:41Z

@rustbot modify labels: +rollup
@bors r+ rollup=never p=5

bors · 2020-07-13T23:26:42Z

📌 Commit 2f20d96 has been approved by Manishearth

bors · 2020-07-13T23:26:43Z

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

bors · 2020-07-13T23:26:55Z

⌛ Testing commit 2f20d96 with merge b2dd47473172079861e20c3a18af79fbad7ef826...

bors · 2020-07-14T00:02:15Z

💔 Test failed - checks-actions

Manishearth · 2020-07-14T00:16:04Z

2020-07-14T00:00:54.8395865Z ---- [ui] ui/rfcs/rfc-1014.rs stdout ----
2020-07-14T00:00:54.8396030Z 
2020-07-14T00:00:54.8396165Z error: test run failed!
2020-07-14T00:00:54.8396300Z status: exit code: 101
2020-07-14T00:00:54.8401953Z command: "/emsdk-portable/node/latest/bin/node" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-1014/a.js"
2020-07-14T00:00:54.8402191Z stdout:
2020-07-14T00:00:54.8402533Z ------------------------------------------
2020-07-14T00:00:54.8402615Z 
2020-07-14T00:00:54.8402898Z ------------------------------------------
2020-07-14T00:00:54.8403043Z stderr:
2020-07-14T00:00:54.8403324Z ------------------------------------------
2020-07-14T00:00:54.8403727Z thread 'main' panicked at 'failed printing to stdout: Bad file descriptor (os error 9)', src/libstd/io/stdio.rs:955:9
2020-07-14T00:00:54.8407643Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-07-14T00:00:54.8408046Z 
2020-07-14T00:00:54.8408714Z ------------------------------------------
2020-07-14T00:00:54.8408812Z 
2020-07-14T00:00:54.8408897Z 
2020-07-14T00:00:54.8408978Z 
2020-07-14T00:00:54.8409109Z failures:
2020-07-14T00:00:54.8409401Z     [ui] ui/rfcs/rfc-1014.rs
2020-07-14T00:00:54.8409477Z 
2020-07-14T00:00:54.8409848Z

Manishearth · 2020-07-14T00:17:04Z

@bors retry

seems like stdout closed unexpectedly

bors · 2020-07-14T00:17:15Z

⌛ Testing commit 2f20d96 with merge fb83e6869d24e4a19a8ff4fb8ad5a11066360031...

bors · 2020-07-14T00:50:44Z

💔 Test failed - checks-actions

Manishearth · 2020-07-14T01:00:21Z

Same bug. That test is actually testing stdout stuff, and it's failing consistently on wasm

Manishearth · 2020-07-14T01:02:21Z

That test shouldn't run at all

Lucretiel and others added 30 commits May 31, 2020 00:10

Substantial refactor to the design of LineWriter

37570e8

This commit redesigns LineWriter to work more directly on the internals of BufWriter. This interface change is to enable a future Pull Request in which Stdout can be switched between Line and Block buffered mode.

Updated comments; only pre-flush newline terminated buffers

0f38158

Expressionify LineWriterShim::write

4a1597f

Expressionify write_all

5edad37

x.py fmt

1bf8ba3

Added check for is_write_vectored

e0dfdc6

Add comment describing erroneous_flush_retried

2c3024b

Added test stubs

e89e2e4

Tons of testing updates, other minor changes

b6296e8

- Cleaned up BufWriter::seek - Updated line_vectored test - Updated line_vectored_partial_and_errors test - Added several new tests

Fixed typo in test

e022d34

Code review updates: all minor style fixes

e4328ae

- Renamed write_to_buffer to write_to_buf, for consistency - Fixed references to flush_buf - Optimized `write` to use one less `memchr` call

Add comment

f7650fe

Tidy fixes

7a6a12b

Reimplement flush_buf with a Guard. Longer, but cleaner.

338a2c0

Added comment about BufWrite::write_all

c869638

Improved line_vectored_ignored. Added stylistic semicolon.

61f591e

Fixed bug in write_vectored & empty buffers

2d22c77

Comment updates

2c23b90

Remove inline from write_to_buf

e999ca5

More minor changes

70ba320

- Fixed test after write_vectored bugfix - Some comments

BufWriter::write* methods now use fewer runtime checks

5b1a40c

x.py fix AGAIN

8df5ae0

Fixed corner case related to partial-line buffering

60ab99f

- Fixed partial-line buffering issue - Added tests Thanks @the8472 for catching!

Update comments with relevant issue numbers

38017a3

Clarified comment in partial_multiline_buffering test

59710fb

Document the union keyword

2e21af2

Clarify some parts by applying the suggestions from review

614f773

Co-authored-by: Josh Triplett <josh@joshtriplett.org>

Fix caching issue when building tools.

310c97b

add as_ptr method to raw slices

c478b54

Manishearth added 5 commits July 13, 2020 16:26

Rollup merge of rust-lang#74257 - alex:patch-1, r=joshtriplett

7ff75b1

don't mark linux kernel module targets as a unix environment refs rust-lang#74247 r?@joshtriplett cc: @ehuss

Rollup merge of rust-lang#74285 - wangtheo:issue-71669, r=lcnr

0a7bbce

rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics Added some tests for intrinsics. See rust-lang#71669.

rustbot added the rollup A PR which is a rollup label Jul 13, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 13, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2020

Manishearth mentioned this pull request Jul 14, 2020

Teach bootstrap about target files vs target triples #74251

Merged

Manishearth closed this Jul 14, 2020

Manishearth mentioned this pull request Jul 14, 2020

Substantial refactor to the design of LineWriter #72808

Merged

Manishearth deleted the rollup-2rompkg branch July 18, 2020 01:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 18 pull requests#74308

Rollup of 18 pull requests#74308
Manishearth wants to merge 81 commits intorust-lang:masterfrom
Manishearth:rollup-2rompkg

Manishearth commented Jul 13, 2020

Uh oh!

Manishearth commented Jul 13, 2020

Uh oh!

bors commented Jul 13, 2020

Uh oh!

bors commented Jul 13, 2020

Uh oh!

bors commented Jul 13, 2020

Uh oh!

bors commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

bors commented Jul 14, 2020

Uh oh!

bors commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

Manishearth commented Jul 13, 2020

Uh oh!

Manishearth commented Jul 13, 2020

Uh oh!

bors commented Jul 13, 2020

Uh oh!

bors commented Jul 13, 2020

Uh oh!

bors commented Jul 13, 2020

Uh oh!

bors commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

bors commented Jul 14, 2020

Uh oh!

bors commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

Manishearth commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants