Revert "Compare tagged/niche-filling layout and pick the best one"#74610
Closed
Mark-Simulacrum wants to merge 1 commit intomasterfrom
Closed
Revert "Compare tagged/niche-filling layout and pick the best one"#74610Mark-Simulacrum wants to merge 1 commit intomasterfrom
Mark-Simulacrum wants to merge 1 commit intomasterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
We can re-land this PR at a later point if there's a way to recover the perf regression here, but given the pretty large variety of performance regressions over the last week it seems good to eagerly revert this to be better able to evaluate the new version. |
Member
Author
|
Gah it seems like our CI didn't like the auto-generated PR made by GitHub, I'll recreate this. |
Member
Author
|
Closing in favor of #74611. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #74069. It caused a performance regression, see #74069 (comment). perf: https://perf.rust-lang.org/compare.html?start=d3df8512d2c2afc6d2e7d8b5b951dd7f2ad77b02&end=cfade73820883adf654fe34fd6b0b03a99458a51
r? @eddyb
cc @nnethercote