Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
When re-landing this we should be sure to include #74591. |
6 tasks
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit aafe6e1df0964d50fee91d6f3a333f7de147ce8f has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@bors rollup=never Due to perf effects. |
Collaborator
|
☔ The latest upstream changes (presumably #74578) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
revert-gimli
branch
from
aafe6e1 to
b747a33
Compare
Member
Author
|
@bors r=nnethercote |
Collaborator
|
📌 Commit b747a33 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Contributor
|
This improved perf as expected. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2020
… r=Mark-Simulacrum std: Switch from libbacktrace to gimli (take 2) This is the second attempt to land rust-lang#73441 after being reverted in rust-lang#74613. Will be gathering precise perf numbers here in this take. Closes rust-lang#71060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts 4cbd265 028f8d7 13db3cc d7a36d8 (and technically 79673d3 but it's made empty by previous reverts).
The current plan is to land this PR as a temporary change, so that we can get a better handle on the regressions introduced by it. Trying to fix/examine them in master is difficult, and we want to be better able to evaluate them without impact to other PRs being landed in the mean time.
That said, it is currently my belief that gimli, in one form or another, will need to land sometime soon. I think it's quite likely that it may slip a week or two, but I would personally push for re-landing it then "regardless" of the regressions. We should try to focus efforts on understanding and removing as much of the performance impact as possible, as everyone pretty much agrees that it should be quite minimal (and entirely in the linker, basically).
r? @nnethercote