Add --output-format json for Rustdoc on nightly#74955
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 31, 2020
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
tmandry
approved these changes
Jul 30, 2020
Member
tmandry
left a comment
tmandry
left a comment
There was a problem hiding this comment.
Looks good to me. Someone on the rustdoc team should take a look also.
Member
Member
|
Looks good to me, thanks! r=me once CI passed |
Member
|
@bors r=GuillaumeGomez |
Collaborator
|
📌 Commit 48c6f05 has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors rollup=always |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Member
|
@rustbot modify labels +A-rustdoc-json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the previously deprecated
--output-formatflag so it can be used on nightly to host the experimental implementation of rfc/2963. The actual implementation will come in later PRs so for now there's just a stub that gives you an ICE.I'm pretty sure that the logic I added makes it inaccessible from stable, but someone should double check that. @tmandry @jyn514