[beta] Make ClashingExternDeclarations Allow by default.#74966
Merged
bors merged 1 commit intorust-lang:betafrom Aug 9, 2020
Merged
[beta] Make ClashingExternDeclarations Allow by default.#74966bors merged 1 commit intorust-lang:betafrom
bors merged 1 commit intorust-lang:betafrom
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup=never |
Collaborator
|
📌 Commit 1625966 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #73990 (comment), this PR changes
clashing_extern_declarationsto allow-by-default to sidestep current false positives & negatives on the beta branch.Note that the changes to fix the issue properly have been merged to master (see #73990), but those changes will have to arrive on the next release train.