Document unsafety in library/core/src/slice/mod.rs#75066
Document unsafety in library/core/src/slice/mod.rs#75066bors merged 6 commits intorust-lang:masterfrom
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Looks good overall! I have added some inline comments, some of which are only small nits.
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Thanks for the quick update and for not amending/force-pushing -- a separate commit makes reviewing updates for these kinds of PRs a lot easier.
Three inline comments still.
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Just one point left!
…y-comments, r=Mark-Simulacrum Accept more safety comments This accepts more `// SAFETY:` comments from `tidy`. This is done after the current behaviour of requiring text one the same line (because spaces are stripped so the last space never pass if there is no text on the same line) bit me once more in rust-lang#75066 This could potentially accept empty `// SAFETY:` comments but `tidy` is an internal tool used only here so my reasoning is reviews will catch those.
|
@bors r+ rollup=iffy Again, thanks a lot! |
|
📌 Commit a308e74 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
@bors treeclosed- |
|
☀️ Test successful - checks-actions, checks-azure |
6 participants
Restart where #73555 left off, helping with #66219.