Move to intra-doc links in library/std/src/path.rs#75293
Move to intra-doc links in library/std/src/path.rs#75293bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
A-intra-doc-links
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This would be fixed by #75176 if I could get it working. |
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Looks great ❤️ Thanks so much!
| /// perfectly valid for some OS. | ||
| /// | ||
| /// [`&str`]: ../primitive.str.html | ||
| /// [`&str`]: str |
| /// [`Cow<str>`]: ../borrow/enum.Cow.html | ||
| /// [U+FFFD]: ../char/constant.REPLACEMENT_CHARACTER.html | ||
| /// [`Cow<str>`]: Cow | ||
| /// [U+FFFD]: super::char::REPLACEMENT_CHARACTER |
There was a problem hiding this comment.
nit: I think this would be more clear as
| /// [U+FFFD]: super::char::REPLACEMENT_CHARACTER | |
| /// [U+FFFD]: crate::char::REPLACEMENT_CHARACTER |
| /// | ||
| /// [`Cow<str>`]: ../borrow/enum.Cow.html | ||
| /// [U+FFFD]: ../char/constant.REPLACEMENT_CHARACTER.html | ||
| /// [`Cow<str>`]: Cow |
|
LGTM at a glance. @jyn514 is there a reason why you didn't r+ yet? |
|
I was waiting to see if @poliorcetics wanted to address the nit. But it can always be fixed in a follow-up PR. @bors r+ rollup |
|
📌 Commit 6d77e40 has been approved by |
bors
added
S-waiting-on-bors
|
Ah sorry, I didn't have time yesterday and forgot all about it till I got your ping today. I plan to continue working on the original issue, if I haven't revisited it once this is merged remind me, I'll do it |
|
☀️ Test successful - checks-actions, checks-azure |
jyn514
removed
the
T-rustdoc
7 participants
Helps with #75080.
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
Known issue: The following links are broken (they are inside trait impls, undocumented in this file, inheriting from the original doc):
Hasher]Self] (referencing../primitive.slice.html)Ordering]