Merged
Conversation
Member
Author
|
@bors rollup=never |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 99f0052 has been approved by |
Member
Author
|
cc @nnethercote |
Member
|
I figured we could land this and check perf after it lands, by the way - it won't get rolled up already (thanks!) and shouldn't be a regression. |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Contributor
|
Perf results from the landing. A bit weird; lots of improvements but some regressions as well, most in the incr-patched runs. I'm disappointed it's not a clearer and more uniform win, like I saw in my local results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
r? @Mark-Simulacrum