Add queries for LocalDefId <-> HirId conversion (take 2)#75641
Add queries for LocalDefId <-> HirId conversion (take 2)#75641Aaron1011 wants to merge 6 commits intorust-lang:masterfrom
Conversation
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 7905f148d2cd3c50732d21d3f9d2ef0e78c7bc57 with merge b3756ef883e14717e30163245752aaa3cfce2f48... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued b3756ef883e14717e30163245752aaa3cfce2f48 with parent e8df0b8, future comparison URL. |
|
Finished benchmarking try commit (b3756ef883e14717e30163245752aaa3cfce2f48): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
7905f14 to
6397e59
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 6397e59300801217175196ff8b8d8493185abb57 with merge b2d89c78f6016d72d0f92bd3b9539328f9c6797c... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued b2d89c78f6016d72d0f92bd3b9539328f9c6797c with parent b287b56, future comparison URL. |
|
Finished benchmarking try commit (b2d89c78f6016d72d0f92bd3b9539328f9c6797c): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 93baa539947593b790ccf508fb9a2c85f08d8900 with merge b674bc729e74dae1904c28716af364e06848a609... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued b674bc729e74dae1904c28716af364e06848a609 with parent be97d13, future comparison URL. |
|
Finished benchmarking try commit (b674bc729e74dae1904c28716af364e06848a609): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Now that LocalDefId <-> HirId conversions are query-ified, we should never get to this point.
|
Ping from triage, there's merge conflicts now. |
|
ping from triage, this has sat idle for a few weeks. |
|
Closing this due to inactivity. Thanks |
|
@Aaron1011 Maybe close this PR? |
This is a second attempt at PR #70039.
Fixes #62649
I've left the workaround code from #62649 in place, but changed it to
bug!instead of bail out.