hir: consistent use and naming of lang items#75666
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 25, 2020
Merged
Conversation
Contributor
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lcnr
approved these changes
Aug 20, 2020
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
IMO this is a fairly huge improvement, not sure how much T-compiler consensus this needs though 🤷
davidtwco
force-pushed
the
tidy-lang-items
branch
from
f156f43 to
867ddc1
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think this is an improvement, and it's consistent with naming conventions elsewhere, so I'll approve, and if anyone has any objections, they can comment. r=me after rebasing |
This commit adjusts the naming of various lang items so that they are consistent and don't include prefixes containing the target or "LangItem". In addition, lang item variants are no longer exported from the `lang_items` module. Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
tidy-lang-items
branch
from
867ddc1 to
6cc268e
Compare
Member
Author
|
@bors r=varkor |
Collaborator
|
📌 Commit 6cc268e has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the naming of various lang items so that they are consistent and don't include prefixes containing the target or "LangItem". In addition, lang item variants are no longer exported from the
lang_itemsmodule.This is certainly subjective and while I think this is an improvement, if many in the team don't then we can just close this.