Convert core/num/mod.rs to intra-doc links by jyn514 · Pull Request #75807 · rust-lang/rust

jyn514 · 2020-08-22T15:02:23Z

Helps with #75080.
This can't convert the associated constants MAX and MIN until #74489 is merged.

r? @poliorcetics

jyn514 · 2020-08-22T15:03:14Z

Highfive seems to be confused this morning .. cc @rust-lang/infra.

emilyalbini · 2020-08-22T15:17:23Z

Highfive is running, it "just" crashed when trying to assign a reviewer. Haven't looked into why it did that.

library/core/src/num/mod.rs

jyn514 · 2020-08-22T15:35:06Z

@pietroalbini @poliorcetics isn't a member of the rust organization, that might be it.

jyn514 · 2020-08-22T16:00:30Z

Postponing this until I fix #75809 because I don't want to mess around with concat! and stringify!.

poliorcetics · 2020-08-22T17:07:15Z

For what its worth, I saw no problems with the current changes once #75809 is fixed.

LeSeulArtichaut · 2020-08-22T18:49:03Z

I guess every PR should have an assignee, so r? @GuillaumeGomez

jyn514 · 2020-08-22T18:51:02Z

I could probably just assign myself 😆 but I don't mind either way.

GuillaumeGomez · 2020-08-22T19:03:12Z

I don't mind either. :p

As for the concat! and stringify! combo, it was used to have the actual type being used in the examples. That's where the doc-comment crate is coming from. :)

LeSeulArtichaut · 2020-08-22T20:34:42Z

I don't mind either. :p

Ouf!

jyn514 · 2020-12-18T16:48:25Z

FWIW I'm ok with just not having the Self:: links work with --stage 0 until the bootstrap bump in 2 weeks - the standard library will still compile, some of the links will just silently fail. But I don't mind waiting the two weeks either.

jyn514 · 2020-12-30T23:18:52Z

This is ready to go as soon as #79150 lands :) I rebased over it to avoid merge conflicts.

poliorcetics · 2021-01-05T14:31:19Z

#79150 has been merged :)

jyn514 · 2021-01-05T21:14:13Z

@poliorcetics this is waiting on #80660 now 😆 so I can automate the switch with cargo intraconv.

camelid · 2021-01-29T02:27:10Z

I don't think this is blocked any more!

jyn514 · 2021-02-02T17:13:57Z

@camelid #80660 landed in 1.51, which is still on nightly.

camelid · 2021-02-02T21:33:47Z

@camelid #80660 landed in 1.51, which is still on nightly.

Dang, I always forget about the bootstrap bump.

jyn514 · 2021-02-23T13:58:13Z

This is finally ready to land!

poliorcetics

Looks good to me !

jyn514 · 2021-02-24T18:01:00Z

@bors r=poliorcetics rollup

bors · 2021-02-24T18:01:02Z

📌 Commit ea3118c has been approved by poliorcetics

LeSeulArtichaut

Looks good to me too.

Rollup of 16 pull requests Successful merges: - rust-lang#75807 (Convert core/num/mod.rs to intra-doc links) - rust-lang#80534 (Use #[doc = include_str!()] in std) - rust-lang#80553 (Add an impl of Error on `Arc<impl Error>`.) - rust-lang#81167 (Make ptr::write const) - rust-lang#81575 (rustdoc: Name fields of `ResolutionFailure::WrongNamespace`) - rust-lang#81713 (Account for associated consts in the "unstable assoc item name colission" lint) - rust-lang#82078 (Make char and u8 methods const) - rust-lang#82087 (Fix ICE caused by suggestion with no code substitutions) - rust-lang#82090 (Do not consider using a semicolon inside of a different-crate macro) - rust-lang#82213 (Slices for vecs) - rust-lang#82214 (Remove redundant to_string calls) - rust-lang#82220 (fix the false 'defined here' messages) - rust-lang#82313 (Update normalize.css to 8.0.1) - rust-lang#82321 (AST: Remove some unnecessary boxes) - rust-lang#82364 (Improve error msgs when found type is deref of expected) - rust-lang#82514 (Update Clippy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

jyn514 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2020

GuillaumeGomez reviewed Aug 22, 2020

View reviewed changes

library/core/src/num/mod.rs Outdated Show resolved Hide resolved

jyn514 mentioned this pull request Aug 22, 2020

Self does not work in intra-doc links for primitives #75809

Closed

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2020

LeSeulArtichaut added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2020

rust-highfive assigned GuillaumeGomez Aug 22, 2020

jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020

This comment has been minimized.

Sign in to view

jyn514 force-pushed the num-intra-link branch from ac7de01 to b830459 Compare December 1, 2020 21:54

jyn514 mentioned this pull request Dec 30, 2020

Remove all doc_comment!{} hacks by using #[doc = expr] where needed. #79150

Merged

jyn514 force-pushed the num-intra-link branch from b830459 to 90a25ea Compare December 30, 2020 23:10

This comment has been minimized.

Sign in to view

jyn514 mentioned this pull request Dec 31, 2020

Rustdoc treats primitive disambiguators incorrectly #80559

Closed

This comment has been minimized.

Sign in to view

camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 29, 2021

jyn514 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2021

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 23, 2021

jyn514 added 2 commits February 23, 2021 08:54

Convert core/num/mod.rs to intra-doc links

2179313

Fix link

ea3118c

jyn514 force-pushed the num-intra-link branch from dbc544e to ea3118c Compare February 23, 2021 13:57

jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021

poliorcetics approved these changes Feb 24, 2021

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2021

LeSeulArtichaut approved these changes Feb 24, 2021

View reviewed changes

Dylan-DPC-zz mentioned this pull request Feb 25, 2021

Rollup of 16 pull requests #82517

Merged

bors merged commit c9cf922 into rust-lang:master Feb 25, 2021

rustbot added this to the 1.52.0 milestone Feb 25, 2021

jyn514 deleted the num-intra-link branch February 25, 2021 18:21

Uh oh!

Conversation

jyn514 commented Aug 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jyn514 commented Aug 22, 2020

Uh oh!

emilyalbini commented Aug 22, 2020

Uh oh!

Uh oh!

jyn514 commented Aug 22, 2020

Uh oh!

jyn514 commented Aug 22, 2020

Uh oh!

poliorcetics commented Aug 22, 2020

Uh oh!

LeSeulArtichaut commented Aug 22, 2020

Uh oh!

jyn514 commented Aug 22, 2020

Uh oh!

GuillaumeGomez commented Aug 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LeSeulArtichaut commented Aug 22, 2020

Uh oh!

This comment has been minimized.

jyn514 commented Dec 18, 2020

Uh oh!

jyn514 commented Dec 30, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

poliorcetics commented Jan 5, 2021

Uh oh!

jyn514 commented Jan 5, 2021

Uh oh!

This comment has been minimized.

camelid commented Jan 29, 2021

Uh oh!

jyn514 commented Feb 2, 2021

Uh oh!

camelid commented Feb 2, 2021

Uh oh!

jyn514 commented Feb 23, 2021

Uh oh!

poliorcetics left a comment

Choose a reason for hiding this comment

Uh oh!

jyn514 commented Feb 24, 2021

Uh oh!

bors commented Feb 24, 2021

Uh oh!

LeSeulArtichaut left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jyn514 commented Aug 22, 2020 •

edited

Loading

GuillaumeGomez commented Aug 22, 2020 •

edited

Loading