Fix intra-doc links on pub re-exports#76082
Merged
bors merged 3 commits intorust-lang:masterfrom Sep 5, 2020
Merged
Conversation
This removes the incorrect error, but doesn't show the documentation anywhere.
jyn514
added
C-bug
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Aug 30, 2020
Member
|
The current code looks good though. Ping me once it's fixed. ;) |
Member
Author
|
@GuillaumeGomez the tests are failing because this documentation is never displayed. It seems weird that it's silently ignored, I can change the test but are you sure this should be merged as is? |
Member
|
If the documentation isn't shown, it's invalid so please this issue first. ;) |
Member
Author
|
We discussed this on Discord: the documentation is never shown for pub re-exports. That's not introduced by this PR, that's an existing behavior. So it's fine for now to just fix the bugs in intra-doc links, but we should have a conversation about whether we want to show docs on re-exports. |
Member
Author
|
I think I can replicate the same bug with |
Member
Author
It's not possible to write |
Member
Author
|
jyn514
force-pushed
the
top-level-links
branch
from
7beb59d to
c204194
Compare
jyn514
changed the title
…r around documenting re-exports
jyn514
force-pushed
the
top-level-links
branch
from
c204194 to
e885f00
Compare
ollie27
reviewed
Aug 30, 2020
Now this actually tests the links are generated correctly
Member
Author
|
Updated! |
ollie27
added
the
T-rustdoc
Member
Author
|
ping @GuillaumeGomez - is this waiting on anything? |
Member
|
Nope, all good! @bors: r=ollie27,GuillaumeGomez |
Collaborator
|
📌 Commit d715015 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit d715015 with merge 22967492ab8fd2d94ffafc1651b6b551ca2edaaa... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit d715015 with merge c137084a9ed560b4e783ab4b0e8b2d2578821dbd... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
|
@bors retry 5 hour timeout on |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
…uillaumeGomez Fix intra-doc links on pub re-exports Partial fix for rust-lang#76073 - This removes the incorrect error, but doesn't show the documentation anywhere. r? @GuillaumeGomez
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
…uillaumeGomez Fix intra-doc links on pub re-exports Partial fix for rust-lang#76073 - This removes the incorrect error, but doesn't show the documentation anywhere. r? @GuillaumeGomez
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 5, 2020
…uillaumeGomez Fix intra-doc links on pub re-exports Partial fix for rust-lang#76073 - This removes the incorrect error, but doesn't show the documentation anywhere. r? @GuillaumeGomez
This was referenced Sep 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75695 (Add a regression test for issue-72793) - rust-lang#75741 (Refactor byteorder to std in rustc_middle) - rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features) - rust-lang#75994 (`impl Rc::new_cyclic`) - rust-lang#76060 (Link vec doc to & reference) - rust-lang#76078 (Remove disambiguators from intra doc link text) - rust-lang#76082 (Fix intra-doc links on pub re-exports) - rust-lang#76254 (Fold length constant in Rvalue::Repeat) - rust-lang#76258 (x.py check checks tests/examples/benches) - rust-lang#76263 (inliner: Check for codegen fn attributes compatibility) - rust-lang#76285 (Move jointness censoring to proc_macro) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #76073 - This removes the incorrect error, but doesn't show the documentation anywhere.
r? @GuillaumeGomez