Stabilize hint::spin_loop by pickfire · Pull Request #76097 · rust-lang/rust

pickfire · 2020-08-30T02:38:20Z

Partially fix #55002, deprecate in another release

library/core/src/sync/atomic.rs

jyn514 · 2020-08-31T14:27:57Z

 error: the feature `renamed_spin_loop` has been stable since 1.47.0 and no longer requires an attribute to enable
   --> library/std/src/lib.rs:295:12
    |
295 | #![feature(renamed_spin_loop)]
    |            ^^^^^^^^^^^^^^^^^

Needs cfg_attr(bootstrap, feature(renamed_spin_loop))

pickfire · 2020-08-31T15:17:08Z

 error: the feature `renamed_spin_loop` has been stable since 1.47.0 and no longer requires an attribute to enable
   --> library/std/src/lib.rs:215:32
    |
215 | #![cfg_attr(bootstrap, feature(renamed_spin_loop))]
    |                                ^^^^^^^^^^^^^^^^^
    |
    = note: `-D stable-features` implied by `-D warnings`

error: aborting due to previous error

error: could not compile `std`.

Is it that it should be #![cfg_attr(not(bootstrap), feature(renamed_spin_loop))]?

KodrAus

Is it that it should be #![cfg_attr(not(bootstrap), feature(renamed_spin_loop))]?

I think we can actually just remove the renamed_spin_loop altogether, since that's what we're stabilizing. At least that seems to work for me locally 🙂

library/core/src/hint.rs

pickfire · 2020-09-05T01:21:37Z

I think we can actually just remove the renamed_spin_loop altogether, since that's what we're stabilizing. At least that seems to work for me locally slightly_smiling_face

Oh, I forgot that we could remove it.

KodrAus · 2020-09-11T00:26:44Z

@bors try

bors · 2020-09-11T00:27:12Z

⌛ Trying commit f7ee5dad97d39755e8549c2eeb9121b0c2101477 with merge e76d95063a57c76c55da09725e42150bdfde978b...

bors · 2020-09-11T01:14:11Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: e76d95063a57c76c55da09725e42150bdfde978b (e76d95063a57c76c55da09725e42150bdfde978b)

KodrAus

Thanks @pickfire!

I've just left a few little suggestions, but I think this is looking good.

library/core/src/hint.rs

library/core/src/sync/atomic.rs

KodrAus · 2020-09-22T01:31:56Z

@bors try

bors · 2020-09-22T01:32:12Z

⌛ Trying commit 3d6b411233283c879dc1988ab031905c36e35cbb with merge b828e07c76cedb02561ae676718d3109080009c9...

bors · 2020-09-22T02:17:05Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: b828e07c76cedb02561ae676718d3109080009c9 (b828e07c76cedb02561ae676718d3109080009c9)

KodrAus · 2020-10-05T02:16:25Z

Just circling back around to this now. It looks like we've got a happy build now! @pickfire would you like to update the example? After that I think this will be good to go, but we might want to bump the stabilization to 1.48.0.

KodrAus · 2020-10-05T02:18:21Z

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

jyn514 · 2020-10-05T02:48:29Z

I think you mean 1.49 -- 1.48 will be promoted to beta on Tuesday.

pickfire · 2020-10-05T07:34:33Z

@KodrAus Example is updated. Thanks for the ping.

pickfire · 2020-10-05T10:54:48Z

@KodrAus Sorry, I accidentally rebased the wrong commit and your commits were gone, I felt lazy to reflog it so I just added the co-authored to the commit message instead.

jyn514 · 2020-11-06T16:05:40Z

@bors r=KodrAus

bors · 2020-11-06T16:05:42Z

📌 Commit e8b5be5 has been approved by KodrAus

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? `@KodrAus`

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? ``@KodrAus``

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? ```@KodrAus```

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? ````@KodrAus````

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? `````@KodrAus`````

Rollup of 19 pull requests Successful merges: - rust-lang#76097 (Stabilize hint::spin_loop) - rust-lang#76227 (Stabilize `Poll::is_ready` and `is_pending` as const) - rust-lang#78065 (make concurrency helper more pleasant to read) - rust-lang#78570 (Remove FIXME comment in print_type_sizes ui test suite) - rust-lang#78572 (Use SOCK_CLOEXEC and accept4() on more platforms.) - rust-lang#78658 (Add a tool to run `x.py` from any subdirectory) - rust-lang#78706 (Fix run-make tests running when LLVM is disabled) - rust-lang#78728 (Constantify `UnsafeCell::into_inner` and related) - rust-lang#78775 (Bump Rustfmt and RLS) - rust-lang#78788 (Correct unsigned equivalent of isize to be usize) - rust-lang#78811 (Make some std::io functions `const`) - rust-lang#78828 (use single char patterns for split() (clippy::single_char_pattern)) - rust-lang#78841 (Small cleanup in `TypeFoldable` derive macro) - rust-lang#78842 (Honor the rustfmt setting in config.toml) - rust-lang#78843 (Less verbose debug logging from inlining integrator) - rust-lang#78852 (Convert a bunch of intra-doc links) - rust-lang#78860 (rustc_resolve: Use `#![feature(format_args_capture)]`) - rust-lang#78861 (typo and formatting) - rust-lang#78865 (Don't fire `CONST_ITEM_MUTATION` lint when borrowing a deref) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned KodrAus Aug 30, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2020

pickfire force-pushed the stabilize-spin-loop branch from dcb273e to 470f3f2 Compare August 30, 2020 02:41

nagisa reviewed Aug 31, 2020

View reviewed changes

library/core/src/sync/atomic.rs Outdated Show resolved Hide resolved

jyn514 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 31, 2020

pickfire force-pushed the stabilize-spin-loop branch from 470f3f2 to f3155d1 Compare August 31, 2020 15:03

KodrAus reviewed Sep 1, 2020

View reviewed changes

library/core/src/hint.rs Outdated Show resolved Hide resolved

pickfire force-pushed the stabilize-spin-loop branch from f3155d1 to f7ee5da Compare September 5, 2020 01:22

KodrAus reviewed Sep 11, 2020

View reviewed changes

library/core/src/hint.rs Outdated Show resolved Hide resolved

library/core/src/hint.rs Outdated Show resolved Hide resolved

library/core/src/hint.rs Outdated Show resolved Hide resolved

library/core/src/sync/atomic.rs Outdated Show resolved Hide resolved

jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 13, 2020

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2020

pickfire force-pushed the stabilize-spin-loop branch from 288033a to 6b4a184 Compare October 5, 2020 10:54

pickfire force-pushed the stabilize-spin-loop branch from 6b4a184 to badff9c Compare October 5, 2020 13:08

jyn514 closed this Nov 6, 2020

jyn514 reopened this Nov 6, 2020

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020

Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…

8a27822

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? `@KodrAus`

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 12 pull requests #78831

Closed

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020

Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…

309522a

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? ``@KodrAus``

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 15 pull requests #78838

Closed

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020

Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…

ebe0a23

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? ```@KodrAus```

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 16 pull requests #78846

Closed

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020

Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…

c68f3b7

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? ````@KodrAus````

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 15 pull requests #78851

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 8, 2020

Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…

548e1b9

…rAus Stabilize hint::spin_loop Partially fix rust-lang#55002, deprecate in another release r? `````@KodrAus`````

Dylan-DPC-zz mentioned this pull request Nov 8, 2020

Rollup of 15 pull requests #78870

Closed

m-ou-se mentioned this pull request Nov 8, 2020

Rollup of 19 pull requests #78874

Merged

bors merged commit 1f034f7 into rust-lang:master Nov 8, 2020

rustbot added this to the 1.49.0 milestone Nov 8, 2020

pickfire deleted the stabilize-spin-loop branch November 8, 2020 17:47

pickfire mentioned this pull request Dec 9, 2020

Clarify docs regarding sleep of zero duration #79849

Merged

camelid mentioned this pull request Jan 3, 2021

Tracking issue for hint::spin_loop (renamed sync::atomic::spin_loop_hint) #55002

Closed

3 tasks

JEnoch mentioned this pull request Nov 25, 2021

Missing package: eclipse-zenoh piwheels/packages#263

Closed

4 tasks

Uh oh!

Conversation

pickfire commented Aug 30, 2020

Uh oh!

Uh oh!

jyn514 commented Aug 31, 2020

Uh oh!

pickfire commented Aug 31, 2020

Uh oh!

KodrAus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pickfire commented Sep 5, 2020

Uh oh!

KodrAus commented Sep 11, 2020

Uh oh!

bors commented Sep 11, 2020

Uh oh!

bors commented Sep 11, 2020

Uh oh!

KodrAus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KodrAus commented Sep 22, 2020

Uh oh!

bors commented Sep 22, 2020

Uh oh!

bors commented Sep 22, 2020

Uh oh!

KodrAus commented Oct 5, 2020

Uh oh!

KodrAus commented Oct 5, 2020

Uh oh!

jyn514 commented Oct 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pickfire commented Oct 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pickfire commented Oct 5, 2020

Uh oh!

jyn514 commented Nov 6, 2020

Uh oh!

bors commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jyn514 commented Oct 5, 2020 •

edited

Loading

pickfire commented Oct 5, 2020 •

edited

Loading