Merged
Conversation
This info was lost in rust-lang#74334.
- Use prettier syntax for codegen-units defaults - Remove comment about parallelism that only made sense for specific values of codegen-units - Be more specific about what `verbose-tests` does
* Adds missing "tail" spans (spans that continue beyond the end of overlapping spans) * Adds a caret to highlight empty spans associated with MIR elements that have a position, but otherwise would not be visible. * Adds visual pointing brackets at the beginning and end of each span
Co-authored-by: Peter Todd <pete@petertodd.org>
const instead of multiple target_pointer_width checks.
Replace lshift with multiply Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
There were no undocumented unsafe blocks in the file.
Introduce a compiler option to let rustc combines all regular CGUs into a single one at the end of compilation. Part of Issue rust-lang#64191
(clippy::redundant_clone)
Add `-Z combine_cgu` flag Introduce a compiler option to let rustc combines all regular CGUs into a single one at the end of compilation. Part of Issue rust-lang#64191
…sper Improve unresolved use error message "use of undeclared type or module `foo`" doesn't mention that it could be a crate. This error can happen when users forget to add a dependency to `Cargo.toml`, so I think it's important to mention that it could be a missing crate. I've used a heuristic based on Rust's naming conventions. It complains about an unknown type if the ident starts with an upper-case letter, and crate or module otherwise. It seems to work very well. The expanded error help covers both an unknown type and a missing crate case.
Address review comments about config.toml from rustc-dev-guide PR This info was lost in rust-lang#74334. See also rust-lang/rustc-dev-guide#795 (review). r? @Mark-Simulacrum or @eddyb
…iser Improved the MIR spanview output * Adds missing "tail" spans (spans that continue beyond the end of overlapping spans) * Adds a caret to highlight empty spans associated with MIR elements that have a position, but otherwise would not be visible. * Adds visual pointing brackets at the beginning and end of each span <img width="590" alt="Screen Shot 2020-09-03 at 8 38 08 PM" src="https://user-images.githubusercontent.com/3827298/92202571-25510c00-ee34-11ea-89bc-89eea939476d.png"> <img width="1061" alt="Screen Shot 2020-09-03 at 8 41 04 PM" src="https://user-images.githubusercontent.com/3827298/92202629-49145200-ee34-11ea-8fda-fc6e62c80736.png"> <img width="1113" alt="Screen Shot 2020-09-06 at 5 42 57 PM" src="https://user-images.githubusercontent.com/3827298/92339198-ca085f00-f069-11ea-96d1-c01ced50e2ba.png"> <img width="1692" alt="Screen Shot 2020-09-06 at 5 45 54 PM" src="https://user-images.githubusercontent.com/3827298/92339209-d4c2f400-f069-11ea-94c0-b4d36c200878.png"> r? @tmandry FYI: @wesleywiser
Add align to rustc-attrs unstable book
Add a script to automatically update Rust/Clang versions in documentation From rust-lang#76402 (comment). r? @elichai
…evink Add missed spaces to GCC-WARNING.txt
…fackler Convert repetitive target_pointer_width checks to const solution. Simply a quick code tidying change. Not sure if more needs to be said.
Remove a stray ignore-tidy-undocumented-unsafe There were no undocumented unsafe blocks in the file. This shouldn't require any special review.
Capitalize safety comments
…regression, r=oli-obk SessionDiagnostic: Fix non-determinism in generated format string. Fixes rust-lang#76496. r? @oli-obk
…k-Simulacrum Enable GitHub Releases synchronization This PR enables the triagebot feature to automatically populate [GitHub Releases](https://github.com/rust-lang/rust/releases) for this repository based on the changelog. See rust-lang/triagebot#811 for the implementation of this feature on triagebot's side, and more insights on how it works. Note: once this lands people subscribed to the ~~firehose~~ rust-lang/rust repository will probably receive a ton of notifications for all the releases being created, but this should be a one-time thing. r? @Mark-Simulacrum cc @rust-lang/release
…as-schievink remove redundant clones (clippy::redundant_clone)
…=wesleywiser Remove unused PlaceContext::NonUse(NonUseContext::Coverage) r? @richkadel / @wesleywiser
Member
Author
Collaborator
|
📌 Commit 32714eb has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 32714eb with merge afad2d4f650d9575e8ecc319250461f2d3f61966... |
Collaborator
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Author
|
Spurious failure |
tmandry
added
the
A-spurious
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Z combine_cguflag #75094 (Add-Z combine_cguflag)Failed merges:
r? @ghost