do not ICE on bound variables, return `TooGeneric` instead by lcnr · Pull Request #76581 · rust-lang/rust

lcnr · 2020-09-10T17:46:16Z

fixes #73260, fixes #74634, fixes #76595

lcnr · 2020-09-11T16:23:55Z

I am actually not even sure if this PR is correct, as ty::Bound is a lot closer to ty::Infer than to ty::Param.

So the bug is probably somewhere else 🤔

lcnr · 2020-09-11T16:43:07Z

So if we call a function which has a generic constant either in its predicates or its signatures, we have an unevaluated constant which depends on inference variables...

We replace these inference variables with ty::ConstKind::Bound before calling the relevant const eval queries. If we now encounter these bound variables we panic because we can't handle them 🤔

I think dealing with this by emitting TooGeneric seems fine, but I don't yet know enough about this to be absolutely sure

eddyb · 2020-09-19T05:37:44Z

compiler/rustc_middle/src/ty/layout.rs


-            ty::Param(_) | ty::Error(_) => {
+            ty::Bound(..) | ty::Param(_) | ty::Error(_) => {
                return Err(LayoutError::Unknown(ty));


I think this is something I suggested in the past so it's probably fine.

eddyb · 2020-09-19T05:38:56Z

@bors r+ cc @nikomatsakis

bors · 2020-09-19T05:38:58Z

📌 Commit ae85bbb has been approved by eddyb

@nikomatsakis

do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis

Dylan-DPC-zz · 2020-09-19T23:15:02Z

failed in rollup

@bors r-

lcnr · 2020-09-20T08:33:04Z

@bors r=eddyb

bors · 2020-09-20T08:33:05Z

📌 Commit 65b3419 has been approved by eddyb

@nikomatsakis

do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis

@nikomatsakis

do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis

@nikomatsakis

do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis

@nikomatsakis

do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis

…atic-morse Rollup of 13 pull requests Successful merges: - rust-lang#72734 (Reduce duplicate in liballoc reserve error handling) - rust-lang#76131 (Don't use `zip` to compare iterators during pretty-print hack) - rust-lang#76150 (Don't recommend ManuallyDrop to customize drop order) - rust-lang#76275 (Implementation of Write for some immutable ref structs) - rust-lang#76489 (Add explanation for E0756) - rust-lang#76581 (do not ICE on bound variables, return `TooGeneric` instead) - rust-lang#76655 (Make some methods of `Pin` unstable const) - rust-lang#76783 (Only get ImplKind::Impl once) - rust-lang#76807 (Use const-checking to forbid use of unstable features in const-stable functions) - rust-lang#76888 (use if let instead of single match arm expressions) - rust-lang#76914 (extend `Ty` and `TyCtxt` lints to self types) - rust-lang#77022 (Reduce boilerplate for BytePos and CharPos) - rust-lang#77032 (lint missing docs for extern items) Failed merges: r? `@ghost`

rust-highfive assigned nikomatsakis Sep 10, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2020

lcnr added A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` labels Sep 10, 2020

lcnr force-pushed the bound-too-generic branch from 548d468 to ae85bbb Compare September 11, 2020 17:36

lcnr changed the title ~~miri: correctly deal with ConstKind::Bound~~ do not ice on bound variables, return TooGeneric instead Sep 12, 2020

lcnr changed the title ~~do not ice on bound variables, return TooGeneric instead~~ do not ICE on bound variables, return TooGeneric instead Sep 12, 2020

eddyb reviewed Sep 19, 2020

View reviewed changes

eddyb approved these changes Sep 19, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2020

Dylan-DPC-zz mentioned this pull request Sep 19, 2020

Rollup of 17 pull requests #76944

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2020

lcnr added 2 commits September 20, 2020 08:22

miri: correctly deal with ConstKind::Bound

2a00dda

do not ICE on ty::Bound in Layout::compute

6734230

lcnr force-pushed the bound-too-generic branch from ae85bbb to 6734230 Compare September 20, 2020 06:36

update stderr file

65b3419

lcnr force-pushed the bound-too-generic branch from 62378b7 to 65b3419 Compare September 20, 2020 08:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2020

Dylan-DPC-zz mentioned this pull request Sep 21, 2020

Rollup of 14 pull requests #76987

Closed

Dylan-DPC-zz mentioned this pull request Sep 21, 2020

Rollup of 17 pull requests #76988

Closed

lcnr assigned eddyb and unassigned nikomatsakis Sep 21, 2020

Dylan-DPC-zz mentioned this pull request Sep 22, 2020

Rollup of 13 pull requests #77038

Closed

ecstatic-morse mentioned this pull request Sep 22, 2020

Rollup of 13 pull requests #77039

Merged

ecstatic-morse mentioned this pull request Sep 22, 2020

Rollup of 13 pull requests #77040

Closed

bors merged commit 30f1bab into rust-lang:master Sep 22, 2020

rustbot added this to the 1.48.0 milestone Sep 22, 2020

lcnr deleted the bound-too-generic branch September 22, 2020 06:04

lcnr mentioned this pull request Nov 17, 2020

Tracking issue for const generics (RFC 2000) #44580

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

do not ICE on bound variables, return `TooGeneric` instead#76581

do not ICE on bound variables, return `TooGeneric` instead#76581
bors merged 3 commits intorust-lang:masterfrom
lcnr:bound-too-generic

lcnr commented Sep 10, 2020 •

edited

Loading

Uh oh!

lcnr commented Sep 11, 2020

Uh oh!

lcnr commented Sep 11, 2020 •

edited

Loading

Uh oh!

eddyb Sep 19, 2020

Uh oh!

eddyb commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

Dylan-DPC-zz commented Sep 19, 2020

Uh oh!

lcnr commented Sep 20, 2020

Uh oh!

bors commented Sep 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

lcnr commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lcnr commented Sep 11, 2020

Uh oh!

lcnr commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eddyb Sep 19, 2020

Choose a reason for hiding this comment

Uh oh!

eddyb commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

Dylan-DPC-zz commented Sep 19, 2020

Uh oh!

lcnr commented Sep 20, 2020

Uh oh!

bors commented Sep 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lcnr commented Sep 10, 2020 •

edited

Loading

lcnr commented Sep 11, 2020 •

edited

Loading