Suggest const_mut_refs, not const_fn for mutable references in const fn#77136
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 25, 2020
Merged
Suggest const_mut_refs, not const_fn for mutable references in const fn#77136bors merged 2 commits intorust-lang:masterfrom
const_mut_refs, not const_fn for mutable references in const fn#77136bors merged 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
|
I would have thought we could remove |
Contributor
Author
|
I browsed the In other news, we need more |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit e5e5e64 has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2020
…as-schievink Rollup of 15 pull requests Successful merges: - rust-lang#75438 (Use adaptive SVG favicon for rustdoc like other rust sites) - rust-lang#76304 (Make delegation methods of `std::net::IpAddr` unstably const) - rust-lang#76724 (Allow a unique name to be assigned to dataflow graphviz output) - rust-lang#76978 (Documented From impls in std/sync/mpsc/mod.rs) - rust-lang#77044 (Liballoc bench vec use mem take not replace) - rust-lang#77050 (Typo fix: "satsify" -> "satisfy") - rust-lang#77074 (add array::from_ref) - rust-lang#77078 (Don't use an if guard to check equality with a constant) - rust-lang#77079 (Use `Self` in docs when possible) - rust-lang#77081 (Merge two almost identical match arms) - rust-lang#77121 (Updated html_root_url for compiler crates) - rust-lang#77136 (Suggest `const_mut_refs`, not `const_fn` for mutable references in `const fn`) - rust-lang#77160 (Suggest `const_fn_transmute`, not `const_fn`) - rust-lang#77164 (Remove workaround for deref issue that no longer exists.) - rust-lang#77165 (Followup to rust-lang#76673) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #77134.
Prior to #76850, most uses of
&mutinconst fnrequiredinvolved two feature gates,const_mut_refsandconst_fn. The first allowed all mutable borrows of locals. The second allowed only locals, arguments and return values whose types contained&mut. I switched the second check to theconst_mut_refsgate. However, I forgot update the error message with the new suggestion.Alternatively, we could revert to having two different feature gates for this. OP's code never borrows anything mutably, so it didn't need
const_mut_refsin the past, onlyconst_fn. I'd prefer to keep everything under a single gate, however.r? @oli-obk