Suggest that expressions that look like const generic arguments should be enclosed in brackets by varkor · Pull Request #77502 · rust-lang/rust

varkor · 2020-10-03T18:37:03Z

I pulled out the changes for const expressions from #71592 (without the trait object diagnostic changes) and made some small changes; the implementation is @estebank's.

We're also going to want to make some changes separately to account for trait objects (they result in poor diagnostics, as is evident from one of the test cases here), such as an adaption of #72273.

Fixes #70753.

r? @petrochenkov

estebank

Thanks for picking this up @varkor!

src/test/ui/const-generics/min_const_generics/const-expression-suggest-missing-braces.rs

petrochenkov · 2020-10-11T10:49:08Z

I'll get to this next weekend most likely.

compiler/rustc_parse/src/parser/path.rs

...nst-generics/min_const_generics/const-expression-suggest-missing-braces-without-turbofish.rs

varkor · 2020-10-21T21:00:07Z

@petrochenkov: I've moved the functions to diagnostics.rs.

compiler/rustc_parse/src/parser/diagnostics.rs

compiler/rustc_parse/src/parser/expr.rs

varkor · 2020-10-25T12:49:25Z

@petrochenkov: I've added some more tests. The error messages in these cases are not ideal, but they're particularly difficult to handle well.

estebank · 2020-10-25T17:57:42Z

The error messages in these cases are not ideal, but they're particularly difficult to handle well.

Handling >> will be hard but we could potentially keep track of how many < we've seen to decide whether to detect it as bitshift or closing type param (we already have recovery for too many closing > in type params so it would have to interact nicely with it), but I don't think it is necessary just yet as the suggestion does give you enough of a clue as to what to do.

petrochenkov · 2020-10-26T20:59:20Z

r=me with commits squashed.

…enclosed in brackets Co-Authored-By: Esteban Kuber <github@kuber.com.ar>

varkor · 2020-10-26T21:55:18Z

@bors r=petrochenkov

bors · 2020-10-26T21:55:20Z

📌 Commit ac14540 has been approved by petrochenkov

bors · 2020-10-27T09:26:00Z

⌛ Testing commit ac14540 with merge 20b1e05...

bors · 2020-10-27T11:43:09Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 20b1e05 to master...

varkor added A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` labels Oct 3, 2020

rust-highfive assigned petrochenkov Oct 3, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2020

varkor mentioned this pull request Oct 3, 2020

const_generics: parsing fails with const expression in type parameter #70753

Closed

estebank reviewed Oct 3, 2020

View reviewed changes

src/test/ui/const-generics/min_const_generics/const-expression-suggest-missing-braces.rs Outdated Show resolved Hide resolved

src/test/ui/const-generics/min_const_generics/const-expression-suggest-missing-braces.rs Outdated Show resolved Hide resolved

varkor force-pushed the const-generics-suggest-enclosing-braces branch from debf4a7 to 5f8aa8a Compare October 3, 2020 19:04

petrochenkov reviewed Oct 11, 2020

View reviewed changes

compiler/rustc_parse/src/parser/path.rs Outdated Show resolved Hide resolved

compiler/rustc_parse/src/parser/path.rs Outdated Show resolved Hide resolved

compiler/rustc_parse/src/parser/path.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2020

estebank reviewed Oct 12, 2020

View reviewed changes

...nst-generics/min_const_generics/const-expression-suggest-missing-braces-without-turbofish.rs Outdated Show resolved Hide resolved

varkor force-pushed the const-generics-suggest-enclosing-braces branch from c23db00 to b03e75e Compare October 21, 2020 20:29

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2020

camelid reviewed Oct 22, 2020

View reviewed changes

camelid added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` labels Oct 22, 2020

petrochenkov reviewed Oct 24, 2020

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2020

varkor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2020

varkor force-pushed the const-generics-suggest-enclosing-braces branch from e4f2b91 to 9aa3cfb Compare October 25, 2020 13:29

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2020

Suggest expressions that look like const generic arguments should be …

ac14540

…enclosed in brackets Co-Authored-By: Esteban Kuber <github@kuber.com.ar>

varkor force-pushed the const-generics-suggest-enclosing-braces branch from 9aa3cfb to ac14540 Compare October 26, 2020 21:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2020

bors merged commit 20b1e05 into rust-lang:master Oct 27, 2020

rustbot added this to the 1.49.0 milestone Oct 27, 2020

bors mentioned this pull request Oct 27, 2020

implement feature(const_generics_defaults) #75384

Merged

varkor mentioned this pull request Oct 28, 2020

Discuss the possibility of denying bare_trait_objects in 2021 edition rust-lang/lang-team#65

Closed

lcnr mentioned this pull request Nov 17, 2020

Tracking issue for const generics (RFC 2000) #44580

Closed

16 tasks

steffahn mentioned this pull request May 3, 2021

ICE when compiling code #84831

Closed

dwrensha mentioned this pull request May 3, 2023

internal compiler error: no errors encountered even though delay_span_bug issued #111148

Closed

Uh oh!

Conversation

varkor commented Oct 3, 2020

Uh oh!

estebank left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Oct 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varkor commented Oct 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varkor commented Oct 25, 2020

Uh oh!

estebank commented Oct 25, 2020

Uh oh!

petrochenkov commented Oct 26, 2020

Uh oh!

varkor commented Oct 26, 2020

Uh oh!

bors commented Oct 26, 2020

Uh oh!

bors commented Oct 27, 2020

Uh oh!

bors commented Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants