Rename ty::TyKind to ty::TyData, Ty::kind to Ty::data#77768
Rename ty::TyKind to ty::TyData, Ty::kind to Ty::data#77768vandenheuvel wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
Some changes occurred in intra-doc-links. cc @jyn514 |
2b129df to
09d5e86
Compare
09d5e86 to
6d449dc
Compare
6d449dc to
587f9cf
Compare
|
@jackh726 perhaps you could signal your 'LGTM' from zulip also here? |
jackh726
left a comment
There was a problem hiding this comment.
this LGTM, basically just a simple rename. But there are some objections on zulip that I would like to resolve.
|
The MCP has not yet been accepted, this shouldn't be merged until it is. |
|
☔ The latest upstream changes (presumably #77798) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
587f9cf to
4d97376
Compare
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
I asked @eddyb to review as he had some points on Zulip still around the time that I made this PR.
I agree, I included this in my request for review. I think the 10 days have passed now, right? Is the "accepted" label not applied automatically? I left the |
|
☔ The latest upstream changes (presumably #77926) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
I'm going to close this as the MCP is going to be rejected. Thank you so much @vandenheuvel for taking the time to implement this ❤️ |
r? @jackh726