Add non_autolinks lint by GuillaumeGomez · Pull Request #77856 · rust-lang/rust

GuillaumeGomez · 2020-10-12T16:31:12Z

Part of #77501.

r? @jyn514

src/doc/rustdoc/src/lints.md

src/librustdoc/passes/automatic_links.rs

GuillaumeGomez · 2020-10-13T13:48:57Z

Updated!

Cargo.lock

compiler/rustc_session/src/lint/builtin.rs

src/doc/rustdoc/src/lints.md

src/librustdoc/passes/automatic_links.rs

src/test/rustdoc-ui/automatic-links.rs

src/doc/rustdoc/src/lints.md

src/librustdoc/passes/automatic_links.rs

src/test/rustdoc-ui/automatic-links.rs

GuillaumeGomez · 2020-10-15T12:58:25Z

Updated!

src/librustdoc/passes/automatic_links.rs

jyn514

Almost done I think 😆

src/librustdoc/passes/automatic_links.rs

jyn514

r=me with nit fixed. This looks great!

src/librustdoc/passes/automatic_links.rs

jyn514 · 2020-10-15T16:04:39Z

@bors r+

bors · 2020-10-15T16:04:41Z

📌 Commit d7272ea has been approved by jyn514

bors · 2020-11-05T19:12:07Z

📌 Commit 99200f7 has been approved by jyn514,ollie27

bors · 2020-11-05T20:21:17Z

⌛ Testing commit 99200f7 with merge e6005c8699c550cac9e9067c6810cbfc98fde193...

bors · 2020-11-05T21:04:24Z

💔 Test failed - checks-actions

GuillaumeGomez · 2020-11-05T21:15:02Z

Clang build segfaulted O.o

jyn514 · 2020-11-05T21:29:32Z

@bors retry

bors · 2020-11-05T21:47:49Z

⌛ Testing commit 99200f7 with merge 5e9eb53b7cbcb57eb9127d94c57424978b5b5ec9...

bors · 2020-11-05T22:32:54Z

💔 Test failed - checks-actions

jyn514 · 2020-11-05T22:47:36Z

I think this is spurious? cc @rust-lang/infra

failures:

---- src\iter\traits\iterator.rs - iter::traits::iterator::Iterator::all (line 2094) stdout ----
error: linking with `link.exe` failed: exit code: 0xc0000374
  |
  = note: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.27.29110\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "/NXCOMPAT" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustdoctestLmUaDM\\rust_out.rust_out.7rcbfp3g-cgu.0.rcgu.o" "/OUT:C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustdoctestLmUaDM\\rust_out" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustdoctestLmUaDM\\rust_out.33dyzt1ekirinwy8.rcgu.o" "/OPT:REF,NOICF" "/DEBUG" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-std\\x86_64-pc-windows-msvc\\release\\deps" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-std\\release\\deps" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-std\\x86_64-pc-windows-msvc\\release\\build\\compiler_builtins-e9846a1ba5da4b30\\out" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-5daa8f2861899387.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-55f9a87fcbb5c69c.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-1de2da4a837999ca.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-83f583c91688d1ff.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-7869c68dc13262c8.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-8a37dd3c063bee5c.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-8e2543b9bb4b6c4a.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-18be2175fdc4eed3.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-2853593ef96980af.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-675cd8e44a769b7c.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-52a35ce5ec9c1329.rlib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-b619ff4555382b9e.rlib" "advapi32.lib" "ws2_32.lib" "userenv.lib" "msvcrt.lib"
  = note: 

note: `link.exe` returned an unexpected error

note: the Visual Studio build tools may need to be repaired using the Visual Studio installer

note: or a necessary component may be missing from the "C++ build tools" workload

error: aborting due to previous error

Couldn't compile the test.

failures:
    src\iter\traits\iterator.rs - iter::traits::iterator::Iterator::all (line 2094)

test result: FAILED. 2723 passed; 1 failed; 26 ignored; 0 measured; 0 filtered out

@bors retry

…, r=jyn514,ollie27 Add non_autolinks lint Part of rust-lang#77501. r? `@jyn514`

bors · 2020-11-06T04:17:46Z

⌛ Testing commit 99200f7 with merge f92b931...

bors · 2020-11-06T06:59:36Z

☀️ Test successful - checks-actions
Approved by: jyn514,ollie27
Pushing f92b931 to master...

GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 12, 2020

rust-highfive assigned jyn514 Oct 12, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2020

GuillaumeGomez force-pushed the automatic-links-lint branch from 5176e5c to d9fcc03 Compare October 12, 2020 19:30

jyn514 added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Oct 12, 2020

jyn514 reviewed Oct 12, 2020

View reviewed changes

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020

GuillaumeGomez force-pushed the automatic-links-lint branch from 9a4487f to e90446a Compare October 13, 2020 13:48

GuillaumeGomez force-pushed the automatic-links-lint branch 2 times, most recently from 83a13cf to 6c04735 Compare October 13, 2020 15:07

jyn514 reviewed Oct 13, 2020

View reviewed changes

GuillaumeGomez force-pushed the automatic-links-lint branch 3 times, most recently from c23dd19 to edb3444 Compare October 14, 2020 21:06

jyn514 reviewed Oct 15, 2020

View reviewed changes

GuillaumeGomez force-pushed the automatic-links-lint branch 2 times, most recently from d9741d0 to 7b68234 Compare October 15, 2020 11:55

jyn514 reviewed Oct 15, 2020

View reviewed changes

src/librustdoc/passes/automatic_links.rs Outdated Show resolved Hide resolved

src/librustdoc/passes/automatic_links.rs Outdated Show resolved Hide resolved

GuillaumeGomez force-pushed the automatic-links-lint branch from 7b68234 to 715b58b Compare October 15, 2020 14:04

jyn514 reviewed Oct 15, 2020

View reviewed changes

src/librustdoc/passes/automatic_links.rs Outdated Show resolved Hide resolved

src/librustdoc/passes/automatic_links.rs Outdated Show resolved Hide resolved

GuillaumeGomez force-pushed the automatic-links-lint branch from 715b58b to 76e9a1b Compare October 15, 2020 15:36

jyn514 reviewed Oct 15, 2020

View reviewed changes

src/librustdoc/passes/automatic_links.rs Outdated Show resolved Hide resolved

GuillaumeGomez force-pushed the automatic-links-lint branch from 76e9a1b to d7272ea Compare October 15, 2020 15:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 6, 2020

Rollup merge of rust-lang#77856 - GuillaumeGomez:automatic-links-lint…

d6bd33d

…, r=jyn514,ollie27 Add non_autolinks lint Part of rust-lang#77501. r? `@jyn514`

Dylan-DPC-zz mentioned this pull request Nov 6, 2020

Rollup of 11 pull requests #78792

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 6, 2020

bors merged commit f92b931 into rust-lang:master Nov 6, 2020

rustbot added this to the 1.49.0 milestone Nov 6, 2020

GuillaumeGomez deleted the automatic-links-lint branch November 6, 2020 08:54

jyn514 mentioned this pull request Jan 18, 2021

cargo fix doesn't work for rustdoc lints rust-lang/cargo#13025

Open

Uh oh!

Conversation

GuillaumeGomez commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuillaumeGomez commented Oct 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuillaumeGomez commented Oct 15, 2020

Uh oh!

Uh oh!

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jyn514 commented Oct 15, 2020

Uh oh!

bors commented Oct 15, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

GuillaumeGomez commented Nov 5, 2020

Uh oh!

jyn514 commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

jyn514 commented Nov 5, 2020

Uh oh!

bors commented Nov 6, 2020

Uh oh!

bors commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GuillaumeGomez commented Oct 12, 2020 •

edited

Loading