BTreeMap: make PartialCmp/PartialEq explicit and tested#77935
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 16, 2020
ssomers:btree_cleanup_1
Merged
BTreeMap: make PartialCmp/PartialEq explicit and tested#77935bors merged 1 commit intorust-lang:masterfrom ssomers:btree_cleanup_1
bors merged 1 commit intorust-lang:masterfrom
ssomers:btree_cleanup_1
Conversation
rust-highfive
added
the
S-waiting-on-review
ssomers
commented
Oct 14, 2020
Comment on lines
+592
to
+596
| let keys = unsafe { &raw const (*leaf).keys }; | ||
| let vals = unsafe { &raw mut (*leaf).vals }; | ||
| // We must coerce to unsized array pointers because of Rust issue #74679. | ||
| let keys: *const [_] = unsafe { &raw const (*leaf).keys }; | ||
| let vals: *mut [_] = unsafe { &raw mut (*leaf).vals }; | ||
| let keys: *const [_] = keys; | ||
| let vals: *mut [_] = vals; |
Contributor
Author
There was a problem hiding this comment.
Unrelated, makes it easier to remove the lines once they become superfluous.
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit a22cd05 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Oct 15, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#75023 (ensure arguments are included in count mismatch span) - rust-lang#75265 (Add `str::{Split,RSplit,SplitN,RSplitN,SplitTerminator,RSplitTerminator,SplitInclusive}::as_str` methods) - rust-lang#75675 (mangling: mangle impl params w/ v0 scheme) - rust-lang#76084 (Refactor io/buffered.rs into submodules) - rust-lang#76119 (Stabilize move_ref_pattern) - rust-lang#77493 (ICEs should always print the top of the query stack) - rust-lang#77619 (Use futex-based thread-parker for Wasm32.) - rust-lang#77646 (For backtrace, use StaticMutex instead of a raw sys Mutex.) - rust-lang#77648 (Static mutex is static) - rust-lang#77657 (Cleanup cloudabi mutexes and condvars) - rust-lang#77672 (Simplify doc-cfg rendering based on the current context) - rust-lang#77780 (rustc_parse: fix spans on cast and range exprs with attrs) - rust-lang#77935 (BTreeMap: make PartialCmp/PartialEq explicit and tested) - rust-lang#77980 (Fix intra doc link for needs_drop) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on a topic raised in #77612
r? @Mark-Simulacrum