[WIP] Tracking the unsolved variables that was assigned `!` type by blitzerr · Pull Request #78051 · rust-lang/rust

blitzerr · 2020-10-17T13:57:04Z

Addresses #66173

rust-highfive · 2020-10-17T13:57:07Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

blitzerr · 2020-10-17T13:57:20Z

r? @nikomatsakis

compiler/rustc_session/src/lint/builtin.rs

src/test/ui/never_type/never_type_lint.rs

…e of fallback

estebank · 2020-11-01T03:01:14Z

compiler/rustc_session/src/lint/builtin.rs

+    //FIXME: Add explanation.
+    pub FALL_BACK_TO_NEVER_TYPE,
+    Deny,
+    "Unresolved variable might fall back to never_type `!`"


Nitpick: the style for user visible messages is not to have leading upper-case titling.

Suggested change

"Unresolved variable might fall back to never_type `!`"

"unresolved variable might fall back to never_type `!`"

Thanks a lot @estebank I will make the change.

bors · 2020-11-01T19:38:07Z

☔ The latest upstream changes (presumably #75534) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

blitzerr · 2020-11-05T20:03:30Z

@bors try

bors · 2020-11-05T20:03:32Z

@blitzerr: 🔑 Insufficient privileges: not in try users

nikomatsakis · 2020-11-05T20:05:27Z

@bors try

bors · 2020-11-05T20:05:40Z

⌛ Trying commit 20c2094 with merge e1ed1bb65d7f01dd2fb49e022313bc28e06d9560...

rust-log-analyzer · 2020-11-05T20:31:45Z

The job dist-x86_64-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Request a runner to run this job
Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest-xl'
Can't find any online and idle self-hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest-xl'
Found online and idle hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest-xl'
##[section]Finishing: Request a runner to run this job
##[debug]Starting: try (dist-x86_64-linux, ubuntu-latest-xl)
##[debug]Starting: Set up job
Current runner version: '2.273.6'
##[group]Operating System
Ubuntu
---
##[debug]Evaluating job defaults
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v2'
##[debug]Download 'https://api.github.com/repos/actions/checkout/tarball/5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f' to '/home/runner/work/_actions/_temp_42d6ca9f-d06f-40ff-9dd6-059505422b0f/624c3343-e4c5-44a0-a6a1-58c9467342d5.tar.gz'
##[debug]Unwrap 'actions-checkout-5a4ac90' to '/home/runner/work/_actions/actions/checkout/v2'
##[debug]Archive '/home/runner/work/_actions/_temp_42d6ca9f-d06f-40ff-9dd6-059505422b0f/624c3343-e4c5-44a0-a6a1-58c9467342d5.tar.gz' has been unzipped into '/home/runner/work/_actions/actions/checkout/v2'.
Download action repository 'rust-lang/simpleinfra@master'
##[debug]Download 'https://api.github.com/repos/rust-lang/simpleinfra/tarball/825b781f5ce1c08493fb921b0d847d3bf6bc7d91' to '/home/runner/work/_actions/_temp_80d2c7b5-bdf7-45bf-9d11-bd19ff9efd3a/b068d976-be7c-406d-bc3b-c15508cd6386.tar.gz'
##[debug]Unwrap 'rust-lang-simpleinfra-825b781' to '/home/runner/work/_actions/rust-lang/simpleinfra/master'
##[debug]Archive '/home/runner/work/_actions/_temp_80d2c7b5-bdf7-45bf-9d11-bd19ff9efd3a/b068d976-be7c-406d-bc3b-c15508cd6386.tar.gz' has been unzipped into '/home/runner/work/_actions/rust-lang/simpleinfra/master'.
##[debug]action.yml for action: '/home/runner/work/_actions/rust-lang/simpleinfra/master/github-actions/cancel-outdated-builds/action.yml'.
##[debug]Set step 'run1' display name to: 'disable git crlf conversion'
##[debug]Set step 'actionscheckout' display name to: 'checkout the source code'
##[debug]Set step 'run2' display name to: 'configure the PR in which the error message will be posted'
---
  ARTIFACTS_AWS_ACCESS_KEY_ID: AKIA46X5W6CZN24CBO55
  CACHE_DOMAIN: ci-caches.rust-lang.org
##[endgroup]
##[debug]Overwrite 'shell' base on job defaults.
##[debug]/bin/bash --noprofile --norc -e -o pipefail /home/runner/work/_temp/5aab460d-53d7-4fc4-87cf-4dd0a6476258.sh
##[debug]Evaluating condition for step: 'checkout the source code'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
---
::endgroup::
##[endgroup]
::group::Fetching the repository
##[group]Fetching the repository
[command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=2 origin +e1ed1bb65d7f01dd2fb49e022313bc28e06d9560:refs/remotes/origin/try
---
   Compiling tempfile v3.1.0
   Compiling serde_json v1.0.59
   Compiling lint-docs v0.1.0 (/checkout/src/tools/lint-docs)
    Finished release [optimized] target(s) in 8.70s
error: could not determine lint name in /checkout/compiler/rustc_lint_defs/src/builtin.rs:2557: lint name should end with comma, line was `//FIXME: Add explanation.`


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/lint-docs" "--src" "/checkout/compiler" "--out" "/checkout/obj/build/x86_64-unknown-linux-gnu/md-doc/rustc/src/lints" "--rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustc-target" "x86_64-unknown-linux-gnu"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu --include-default-paths src/tools/build-manifest
Build completed unsuccessfully in 0:22:42
Build completed unsuccessfully in 0:22:42
== clock drift check ==
  local time: Thu Nov  5 20:31:35 UTC 2020
  network time: Wed, 04 Nov 2020 23:05:40 GMT
== end clock drift check ==
##[error]Process completed with exit code 1.
##[debug]Evaluating: env.ARTIFACTS_AWS_ACCESS_KEY_ID
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
---
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (false && !env['SKIP_JOB'] && ((github['event_name'] == 'push') || (env['DEPLOY'] == '1') || (env['DEPLOY_ALT'] == '1')))
##[debug]Evaluating condition for step: 'Post checkout the source code'
##[debug]Evaluating: always()
##[debug]Evaluating always:
##[debug]=> true
---
Completed runner diagnostic log upload
Cleaning up orphan processes
Terminate orphan process: pid (6176) (python)
##[debug]Finishing: Complete job
##[debug]Finishing: try (dist-x86_64-linux, ubuntu-latest-xl)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-11-05T20:31:58Z

💔 Test failed - checks-actions

Dylan-DPC-zz · 2020-11-24T14:29:45Z

@blitzerr any updates on this?

nikomatsakis · 2020-12-03T11:31:21Z

Closing in favor of #79366 (I've discussed this with @blitzerr)

rust-highfive assigned estebank Oct 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2020

rust-highfive assigned nikomatsakis and unassigned estebank Oct 17, 2020

bjorn3 reviewed Oct 17, 2020

View reviewed changes

compiler/rustc_session/src/lint/builtin.rs Show resolved Hide resolved

bjorn3 reviewed Oct 17, 2020

View reviewed changes

src/test/ui/never_type/never_type_lint.rs Outdated Show resolved Hide resolved

camelid added the A-type-system Area: Type system label Oct 17, 2020

blitzerr changed the title ~~Tracking the unsolved variables that was assigned ! type~~ [WIP] Tracking the unsolved variables that was assigned ! type Oct 20, 2020

JulianKnodt and others added 3 commits October 31, 2020 00:08

Add regression test

b42a3f1

Tracking all the unsolved variables that was assigned ! type becaus…

d95cc41

…e of fallback

replace todo with FIXME

20c2094

estebank reviewed Nov 1, 2020

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2020

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2020

nikomatsakis closed this Dec 3, 2020

	"Unresolved variable might fall back to never_type `!`"
	"unresolved variable might fall back to never_type `!`"

Uh oh!

Conversation

blitzerr commented Oct 17, 2020

Uh oh!

rust-highfive commented Oct 17, 2020

Uh oh!

blitzerr commented Oct 17, 2020

Uh oh!

Uh oh!

Uh oh!

estebank Nov 1, 2020

Choose a reason for hiding this comment

Uh oh!

blitzerr Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

bors commented Nov 1, 2020

Uh oh!

blitzerr commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

nikomatsakis commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

rust-log-analyzer commented Nov 5, 2020

Uh oh!

bors commented Nov 5, 2020

Uh oh!

Dylan-DPC-zz commented Nov 24, 2020

Uh oh!

nikomatsakis commented Dec 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants