Make ControlFlow #[must_use]#78202
Conversation
46c1a65 to
28a77c4
Compare
|
Hmm, I don't have a good sense for how to decide whether to do this. It makes total sense in the visitor recursion scenario, but seems suboptimal in the updated doctest's scenario of Maybe @rust-lang/libs would have some advice? Sadly there's nothing I could find in the api-guidelines about cc @NoraCodes and @ecstatic-morse, as other participants in the tracking issue, to comment on whether this makes sense in their situations. |
|
There's some discussion on |
|
☔ The latest upstream changes (presumably #78334) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
Suggested by @oli-obk in #78182 (comment).
r? @scottmcm cc #75744