Closed
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
cc @JohnTitor |
JohnTitor
reviewed
Oct 25, 2020
2420379 to
0b38c40
Compare
Member
|
I generally ask that such PRs also bump the libc dep in a Cargo.toml somewhere in the workspace, so we don't accidentally regress in a future PR when rebasing across this change (I've done it before myself, and only noticed when looking at the diff, which for larger Cargo.lock changes is a bit untenable). r=me with that done. |
0b38c40 to
00abef1
Compare
Member
Author
|
@bors r=Mark-Simulacrum |
Collaborator
|
📌 Commit 00abef1 has been approved by |
Contributor
|
@bors rollup=iffy r- failed in #78451 (comment) |
Member
|
Triage: What's the status of this? |
Member
Author
|
There are outstanding issues that need to be resolved before this can land. It still needs to land some day, though, but it likely will be a bump to a different libc version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the version of the libc crate from 0.2.79 to 0.2.80 in order to hopefully fix a build failure when building the standard library for the tier 3
x86_64-unknown-dragonflytarget.