Skip to content

Make all rustdoc functions and structs crate-private#79061

Merged
bors merged 4 commits intorust-lang:masterfrom
jyn514:no-pub
Nov 17, 2020
Merged

Make all rustdoc functions and structs crate-private#79061
bors merged 4 commits intorust-lang:masterfrom
jyn514:no-pub

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 14, 2020

This gives warnings when code is no longer used, which will be helpful when #77820 and #78082 land.

AFAIK no one is using this API.

r? @GuillaumeGomez
cc @rust-lang/rustdoc

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2020
@rust-highfive
Copy link
Contributor

rust-highfive commented Nov 14, 2020

Some changes occurred in intra-doc-links.

cc @jyn514

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2020
@jyn514
Copy link
Member Author

jyn514 commented Nov 14, 2020 •
edited
Loading

This made fff9203 (for #77820) trivial to write, it would have been very tedious to find all the unused code otherwise.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 15, 2020

Sounds fine to me. We can always rethink it later on if needed.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 15, 2020

📌 Commit 6e0daf9eae92ddf88f190f7b37aead438a8a91d7 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2020
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 15, 2020
@bors
Copy link
Collaborator

bors commented Nov 15, 2020

☔ The latest upstream changes (presumably #79070) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2020
@jyn514
Copy link
Member Author

jyn514 commented Nov 15, 2020

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Nov 15, 2020

📌 Commit 9b84c91 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2020
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 15, 2020
Closed
@m-ou-se m-ou-se mentioned this pull request Nov 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2020
@bors
Auto merge of rust-lang#79104 - m-ou-se:rollup-v74492y, r=m-ou-se
c6a6105 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#74989 (Implement `Index` and `IndexMut` for arrays)
 - rust-lang#76339 (Test structural matching for all range types)
 - rust-lang#77691 (Rename/Deprecate LayoutErr in favor of LayoutError)
 - rust-lang#78364 (Update RELEASES.md for 1.48.0)
 - rust-lang#78678 (Add tests and improve rendering of cfgs on traits)
 - rust-lang#78714 (Simplify output capturing)
 - rust-lang#78769 (Remove unneeded lifetimes in array/mod.rs)
 - rust-lang#78903 (BTreeMap: test chaotic ordering & other bits & bobs)
 - rust-lang#79032 (improve type const mismatch errors)
 - rust-lang#79061 (Make all rustdoc functions and structs crate-private)
 - rust-lang#79087 (Update E0744 about control flow in `const` contexts to accurately describe when the error is triggered and why)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c3da682 into rust-lang:master Nov 17, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 17, 2020
@aDotInTheVoid aDotInTheVoid mentioned this pull request Nov 29, 2020
Merged
5 tasks
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Dec 1, 2020
@m-ou-se
Rollup merge of rust-lang#79539 - aDotInTheVoid:json-mvp, r=jyn514,Gu…
f401e9e 
…illaumeGomez

Rustdoc: JSON backend experimental impl, with new tests.

Based on rust-lang#75114 by `@P1n3appl3`

The first commit is all of rust-lang#75114, but squased to 1 commit, as that was much easier to rebase onto master.

The git history is a mess, but I think I'll edit it after review, so it's obvious whats new.

## Still to do

- [ ] Update docs.
- [ ] Add bless option to tests.
- [ ] Add test option for multiple files in same crate.
- [ ] Decide if the tests should check for json to be equal or subset.
- [ ] Go through the rest of the review for the original pr. (This is open because the test system is done(ish), but stuff like [not using a hashmap](rust-lang#75114 (comment)) and [using `CRATE_DEF_INDEX` ](rust-lang#75114 (comment)) hasn't)

I'm also sure how many of these we need to do before landing on nightly, as it would be nice to get this in tree, so it isn't effected by churn like rust-lang#79125, rust-lang#79041, rust-lang#79061

r? `@jyn514`
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2020
@bors
Auto merge of rust-lang#79539 - aDotInTheVoid:json-mvp, r=jyn514
7dc1e85 
Rustdoc: JSON backend experimental impl, with new tests.

Based on rust-lang#75114 by `@P1n3appl3`

The first commit is all of rust-lang#75114, but squased to 1 commit, as that was much easier to rebase onto master.

The git history is a mess, but I think I'll edit it after review, so it's obvious whats new.

## Still to do

- [ ] Update docs.
- [ ] Add bless option to tests.
- [ ] Add test option for multiple files in same crate.
- [ ] Decide if the tests should check for json to be equal or subset.
- [ ] Go through the rest of the review for the original pr. (This is open because the test system is done(ish), but stuff like [not using a hashmap](rust-lang#75114 (comment)) and [using `CRATE_DEF_INDEX` ](rust-lang#75114 (comment)) hasn't)

I'm also sure how many of these we need to do before landing on nightly, as it would be nice to get this in tree, so it isn't effected by churn like rust-lang#79125, rust-lang#79041, rust-lang#79061

r? `@jyn514`
@jyn514 jyn514 deleted the no-pub branch December 29, 2020 21:59
@rbtcollins rbtcollins mentioned this pull request Apr 23, 2021
Closed
@0xPoe 0xPoe mentioned this pull request Apr 26, 2021
Merged
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Apr 26, 2021
@m-ou-se
Rollup merge of rust-lang#84574 - hi-rustin:rustin-patch-typo, r=jyn514
8b33dfa 
rustdoc: Fix typos in maybe_inline_local fn

Introduced by rust-lang#79061.

r? `@jyn514`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jyn514 @rust-highfive @GuillaumeGomez @bors @rustbot