Merged
Conversation
If the LLVM was externally provided, then we don't currently copy artifacts into the sysroot. This is not necessarily the right choice (in particular, it will require the LLVM dylib to be in the linker's load path at runtime), but the common use case for external LLVMs is distribution provided LLVMs, and in that case they're usually in the standard search path (e.g., /usr/lib) and copying them here is going to cause problems as we may end up with the wrong files and isn't what distributions want. This behavior may be revisited in the future though.
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com> Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Camelid <camelidcamel@gmail.com> Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
…ackline in source rendering
Member
Author
|
@bors r+ p=500 rollup=never |
Collaborator
|
📌 Commit 6142bf6 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 6142bf6 with merge dd09f70a6471d5b30f60b943036d271e9cab6dbf... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
Forgot to include the aarch64 windows fix. @bors r+ p=500 |
Collaborator
|
📌 Commit 7477867 has been approved by |
bors
added
S-waiting-on-bors
Member
|
Can you also include #79141? |
Collaborator
Member
Author
|
@mati865 uh, just saw that, woops. |
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets everything up for beta 1.49.0, and backports the following PRs to it:
This is the same as #79132, but actually targeting the right branch.
r? @ghost
cc @rust-lang/release