Added tests in int module library as a part of #76268#79163
Closed
ayushmishra2005 wants to merge 1 commit intorust-lang:masterfrom
Closed
Added tests in int module library as a part of #76268#79163ayushmishra2005 wants to merge 1 commit intorust-lang:masterfrom
ayushmishra2005 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
Contributor
|
I think this invokes compiler built-in operations for primitives, rather than going through libcore implementation (rather, So, these tests actually exercise the compiler itself, and not the stdlib, and better be left in place. @jyn514 I've noticed that a fair share of #76268 PRs now hit this "not actually stdlib" test. This probably means majority of the library tests are now in their proper place and that we can close that issue? |
Member
Member
|
Closing this since these are testing the compiler and not the standard library. |
Member
|
As a general rule, if the test would work with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Arith Tests library as a part of #76268
r? @matklad