Give a better error for download-ci-llvm if .xz is not supported#80581
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 2, 2021
Merged
Give a better error for download-ci-llvm if .xz is not supported#80581bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
Author
|
It's possible to special case this so that it will work before 1.51, but since download-ci-llvm was only introduced a couple versions ago I don't think there's a need. The fix is easy enough - using |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Can we tell people a specific version? Maybe python 3 at least? |
Previously: ``` curl: (22) The requested URL returned error: 404 failed to run: curl -# -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmp6ptXJV https://ci-artifacts.rust-lang.org/rustc-builds/99ad5a1a2824fea1ecf60068fd3636beae7ea2da/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz ``` Now: ``` error: XZ support is required to download LLVM help: consider disabling `download-ci-llvm` or using a different version of python Build completed unsuccessfully in 0:00:00 ```
Member
Author
|
Sure, I changed this to recommend python3. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit b5019d6 has been approved by |
Member
|
@bors p=1 |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
Now:
Follow-up to #80435.
r? @Mark-Simulacrum