Merged
Conversation
fixes clippy warnings of type: match_like_matches_macro or_fun_call op_ref needless_return let_and_return single_char_add_str useless_format unnecessary_sort_by match_ref_pats redundant_field_names
So that at least it won't ICE for users whether or not they enable the gate. For developers the FIXMEs are enough.
clippy fixes for librustdoc fixes clippy warnings of type: match_like_matches_macro or_fun_call op_ref needless_return let_and_return single_char_add_str useless_format unnecessary_sort_by match_ref_pats redundant_field_names
…drAus Improve library tracking issue template r? `@KodrAus`
…lacrum Clean bootstrap artifacts on `x.py clean` Closes rust-lang#76519 r? `@Mark-Simulacrum`
…lcnr improve unconditional_panic description The fact that the lint is triggered by the ConstProp pass is an implementation detail, I do not think that this should be mentioned in the description. Cc `@oli-obk` `@ehuss`
`const_generics_defaults`: don't ICE in the unimplemented parts The thought was that we could use `todo!`s to ensure we wouldn't forget to implement parts of the experimental gate. However, that can also lead to a suboptimal experience for users as shown in rust-lang#80589 having both the error/warning about the experimental feature, and the ICE. Fixes rust-lang#80589 r? `@varkor`
Diag: print enum variant instead of enum type Closes rust-lang#80607
Member
Author
|
@bors r+ p=6 rollup=never |
Collaborator
|
📌 Commit 4172756 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
x.py clean#80574 (Clean bootstrap artifacts onx.py clean)const_generics_defaults: don't ICE in the unimplemented parts #80599 (const_generics_defaults: don't ICE in the unimplemented parts)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup