handle generic trait methods in coverage-report tests#80761
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 8, 2021
Merged
handle generic trait methods in coverage-report tests#80761bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
the types of generic instantiations that I found was |
spastorino
approved these changes
Jan 6, 2021
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 3f74fbd has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 7, 2021
…wiser handle generic trait methods in coverage-report tests also make the generic function pattern more specific and remove the extra $ that fails the matching. r? `@wesleywiser` as this was failing the test of rust-lang#76896
Member
|
Failed in rollup: https://github.com/rust-lang-ci/rust/runs/1662914291 |
bors
added
S-waiting-on-author
make the generic function pattern more specific
andjo403
force-pushed
the
generic_coverage
branch
from
3f74fbd to
4f6305b
Compare
Contributor
Author
|
@wesleywiser have fixed the fault. |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 4f6305b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#79675 (Make sure rust-call errors occur correctly for traits) - rust-lang#80372 (Don't panic when an external crate can't be resolved) - rust-lang#80761 (handle generic trait methods in coverage-report tests) - rust-lang#80785 (rustc_ast_pretty: Remove `PrintState::insert_extra_parens`) - rust-lang#80791 (Fix type name in doc example for Iter and IterMut) - rust-lang#80794 (Use Option::map_or instead of `.map(..).unwrap_or(..)`) - rust-lang#80799 (Get rid of custom pretty-printing in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also make the generic function pattern more specific.
r? @wesleywiser
as this was failing the test of #76896