Always collect tokens when we are already inside a collect_tokens call#81029
Always collect tokens when we are already inside a collect_tokens call#81029Aaron1011 wants to merge 1 commit intorust-lang:masterfrom
collect_tokens call#81029Conversation
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #80993) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes rust-lang#81007 This is needed to ensure that the `LazyTokenStream` we use does not include attributes - the outer call may include the attributes, which we don't want to include in the `LazyTokenSTream`.
269553c to
372b567
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. |
|
⌛ Trying commit 372b567 with merge 9f6de25f295e73311e6356b40ebab59069798fce... |
|
☀️ Try build successful - checks-actions |
|
Queued 9f6de25f295e73311e6356b40ebab59069798fce with parent e48eb37, future comparison URL. @rustbot label: +S-waiting-on-perf |
|
Finished benchmarking try commit (9f6de25f295e73311e6356b40ebab59069798fce): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
This is implemented (with some extra performance improvements) in #81017. Once that PR is merged, this PR can be merged with just the test. |
|
Closing in favor of #81177, which accomplishes the same result more efficiently. |
Fixes #81007
This is needed to ensure that the
LazyTokenStreamwe use does notinclude attributes - the outer call may include the attributes, which we
don't want to include in the
LazyTokenSTream.