Avoid describing a method as 'not found' when bounds are unsatisfied#81149
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 28, 2021
Merged
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
This makes the primary error message multi-line. I'm open to any suggestions for a better way of showing this information. |
Contributor
Author
|
r? @estebank |
estebank
reviewed
Jan 18, 2021
Contributor
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
What do you think of the proposed output?
Comment on lines
1
to
10
Contributor
There was a problem hiding this comment.
What do you think if we instead output:
error[E0599]: the method `f` exists for type `u32`, but its trait bounds were not satisfied
--> $DIR/hr-associated-type-bound-2.rs:19:10
|
LL | 1u32.f("abc");
| ^ method not found in `u32` due to unsatisfied trait bounds
|
= note: the following trait bounds were not satisfied:
`<u32 as X<'b>>::U: Clone`
which is required by `u32: X`
Contributor
Author
There was a problem hiding this comment.
That looks good, except for the usage of 'not found' in "method not found in u32 due to unsatisfied trait bounds". I think it should say something like "method cannot be called on u32 due to unsatisfied trait bounds".
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Aaron1011
force-pushed
the
feature/better-no-method-found-err
branch
3 times, most recently
from
fe85c83 to
bb4f70c
Compare
Contributor
Author
|
@estebank I've updated the error message. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit bb4f70c has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 27, 2021
…found-err, r=estebank Avoid describing a method as 'not found' when bounds are unsatisfied Fixes rust-lang#76267 When there is a single applicable method candidate, but its trait bounds are not satisfied, we avoid saying that the method is "not found". Insted, we update the error message to directly mention which bounds are not satisfied, rather than mentioning them in a note.
bors
added
S-waiting-on-author
Fixes rust-lang#76267 When there is a single applicable method candidate, but its trait bounds are not satisfied, we avoid saying that the method is "not found". Insted, we update the error message to directly mention which bounds are not satisfied, rather than mentioning them in a note.
Aaron1011
force-pushed
the
feature/better-no-method-found-err
branch
from
bb4f70c to
dea8a16
Compare
Contributor
Author
|
@bors r=estebank |
Collaborator
|
📌 Commit dea8a16 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@bors r- failed in #81449 (comment) |
bors
added
S-waiting-on-author
Contributor
Author
|
@bors rollup=never |
Contributor
Author
|
Failed due to #81351 adding a new error to a test. I'll rebase this PR once that PR lands in the current rollup. |
Contributor
Author
Collaborator
|
📌 Commit dea8a16 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit dea8a16 with merge e46baecedb47431e475b87aadf0bc1ffed28a0c5... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76267
When there is a single applicable method candidate, but its trait bounds
are not satisfied, we avoid saying that the method is "not found".
Insted, we update the error message to directly mention which bounds are
not satisfied, rather than mentioning them in a note.