[beta] backports

[Mark-Simulacrum]

This backports:

• Update RLS and Rustfmt Update RLS and Rustfmt #81027
• bump rustfmt to v1.4.32 bump rustfmt to v1.4.32 #81093
• Fix handling of malicious Readers in read_to_end Fix handling of malicious Readers in read_to_end #80895
• Fix broken ./x.py install Fix broken ./x.py install #80514
• Fix x.py install not working with relative prefix Fix x.py install not working with relative prefix #80797
• [security] Update mdbook [security] Update mdbook #80688
• rustdoc: Render visibilities succinctly rustdoc: Render visibilities succinctly #80368

r? @ghost

[Mark-Simulacrum]

@bors r+ rollup=never

[bors]

📌 Commit a1edcfbcf55c4aabd67af980370cf6448fcba5b2 has been approved by Mark-Simulacrum

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  EXTRA_VARIABLES: {
 "CI_ONLY_WHEN_SUBMODULES_CHANGED": 1
##[endgroup]
adding extra environment variable CI_ONLY_WHEN_SUBMODULES_CHANGED
linux builder detected, using docker to run the build
##[group]Run src/ci/scripts/should-skip-this.sh
---
   Compiling rustc-ap-rustc_arena v697.0.0
error[E0658]: const generics are unstable
   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_arena-697.0.0/src/lib.rs:136:15
    |
136 | impl<T, const N: usize> IterExt<T> for std::array::IntoIter<T, N> {
    |
    = note: see issue #74878 <https://github.com/rust-lang/rust/issues/74878> for more information
    = note: see issue #74878 <https://github.com/rust-lang/rust/issues/74878> for more information
    = help: add `#![feature(min_const_generics)]` to the crate attributes to enable
   Compiling proc-macro-error-attr v1.0.4
   Compiling proc-macro-error v1.0.4
error: aborting due to previous error

---
   Compiling heck v0.3.1
error[E0658]: const generics are unstable
   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_arena-697.0.0/src/lib.rs:136:15
    |
136 | impl<T, const N: usize> IterExt<T> for std::array::IntoIter<T, N> {
    |
    = note: see issue #74878 <https://github.com/rust-lang/rust/issues/74878> for more information
    = note: see issue #74878 <https://github.com/rust-lang/rust/issues/74878> for more information
    = help: add `#![feature(min_const_generics)]` to the crate attributes to enable
   Compiling byteorder v1.3.4
error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
---
Verifying status of edition-guide...
Verifying status of rls...
This PR updated 'src/tools/rls', verifying if status is 'test-pass'...

We detected that this PR updated 'rls', but its tests failed.

If you do intend to update 'rls', please check the error messages above and
commit another update.

If you do NOT intend to update 'rls', please ensure you did not accidentally
change the submodule at 'src/tools/rls'. You may ask your reviewer for the
proper steps.
{"rls":"build-fail","reference":"test-pass","cargo-miri":"test-fail","rustbook":"test-fail","edition-guide":"test-pass","nomicon":"test-pass","embedded-book":"test-pass","rustfmt":"build-fail","rust-by-example":"test-pass","book":"test-pass","miri":"test-fail"}failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 check-tools

[Mark-Simulacrum]

@bors r-

@Xanewok @calebcartwright it looks like the ap crates are relying on const generics to be stable, but the backports of recent bumps push them back to 1.50 where const generics are not yet stable. This has a number of implications:

• we can't compile these crates easily, though there may be some hacks I can do in rustbuild to get things to work
• we are presumably using a const-generics-stable parser, which has stability implications for rustfmt/rls (though not too significant as that feature is already stable in 1.51)

we'll need to resolve this before we can land this, but if it takes more than a few days I'll probably drop those updates from this PR

[calebcartwright]

Might take some juggling but perhaps as an alternative I could backport the commits for the bug fix to the rustfmt-1.4.30 branch in the rustfmt repo. Then rustfmt submod here on beta could stay on the 1.4.30 branch and just pull in the commit, and then do something similar on the RLS maybe in a new branch off whatever's currently in beta?

[Mark-Simulacrum]

That sounds like a good strategy to me.

[calebcartwright]

Done on the rustfmt side. @Xanewok - let me know if I can do anything to help on the RLS side. Based on what's currently on beta I'm guessing/hoping it's just a matter of bumping the 1.4.29 rustfmt dependency currently in the submod to the now-updated 1.4.30 branch, but not sure if there's anything else on the RLS side that needed to be backported as well

[Xanewok]

Created a https://github.com/rust-lang/rls/tree/rust-1.50 (updates a single commit, starting from https://github.com/rust-lang/rls/tree/2cf84baa5e3c55ac02f42919e67440acb5417125, currently checked out as part of the beta branch) branch that points to the new rustfmt-v1.4.30 branch (updates from 1.4.29), this should be good to go from RLS' side.

[bors]

☔ The latest upstream changes (presumably #81201) made this pull request unmergeable. Please resolve the merge conflicts.

[Mark-Simulacrum]

@bors r+ rollup=never

[bors]

📌 Commit d239ea6 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit d239ea6 with merge 1cd0303...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1cd0303 to beta...