Make ptr::write const by usbalbin · Pull Request #81167 · rust-lang/rust

usbalbin · 2021-01-18T13:26:11Z

~~The code in this PR as of right now is not much more than an experiment.~~

This should, if I am not mistaken, in theory compile and pass the tests once the bootstraping compiler is updated. Thus the PR is blocked on that which should happen some time after the February the 9th. Also we might want to wait for #79989 to avoid regressing performance due to using mem::forget over intrinsics::forget.

rust-highfive · 2021-01-18T13:26:14Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

library/core/src/ptr/mod.rs

oli-obk · 2021-01-19T11:56:28Z

cc @rust-lang/wg-const-eval

library/core/src/ptr/mod.rs

usbalbin · 2021-02-05T19:30:33Z

I have reverted the &mut hack that made this compile without the new bootstrapping compiler. The tests will fail until the bootstrapping compiler is updated(which is expected to happen some time after the 9th).

usbalbin · 2021-02-23T12:39:30Z

Should this work now that #82076 is merged?

RalfJung · 2021-02-23T12:59:52Z

Looks like it still requires const_refs_to_cell?

EDIT: And that makes sense, the check is still unstable of course.

oli-obk · 2021-02-23T16:30:09Z

One more thing, can you either remove the back and forth in the commits or just squash them down to one?

library/core/src/ptr/mod.rs

Constify intrinsics::forget

oli-obk · 2021-02-24T08:38:56Z

@bors r+

Thanks for bearing with us through this back and forth!

bors · 2021-02-24T08:38:57Z

📌 Commit 89c7610 has been approved by oli-obk

usbalbin · 2021-02-24T11:39:07Z

Thank you both for helping me :)

Make ptr::write const ~~The code in this PR as of right now is not much more than an experiment.~~ ~~This should, if I am not mistaken, in theory compile and pass the tests once the bootstraping compiler is updated. Thus the PR is blocked on that which should happen some time after the February the 9th. Also we might want to wait for rust-lang#79989 to avoid regressing performance due to using `mem::forget` over `intrinsics::forget`~~.

Rollup of 16 pull requests Successful merges: - rust-lang#75807 (Convert core/num/mod.rs to intra-doc links) - rust-lang#80534 (Use #[doc = include_str!()] in std) - rust-lang#80553 (Add an impl of Error on `Arc<impl Error>`.) - rust-lang#81167 (Make ptr::write const) - rust-lang#81575 (rustdoc: Name fields of `ResolutionFailure::WrongNamespace`) - rust-lang#81713 (Account for associated consts in the "unstable assoc item name colission" lint) - rust-lang#82078 (Make char and u8 methods const) - rust-lang#82087 (Fix ICE caused by suggestion with no code substitutions) - rust-lang#82090 (Do not consider using a semicolon inside of a different-crate macro) - rust-lang#82213 (Slices for vecs) - rust-lang#82214 (Remove redundant to_string calls) - rust-lang#82220 (fix the false 'defined here' messages) - rust-lang#82313 (Update normalize.css to 8.0.1) - rust-lang#82321 (AST: Remove some unnecessary boxes) - rust-lang#82364 (Improve error msgs when found type is deref of expected) - rust-lang#82514 (Update Clippy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…Mark-Simulacrum Make copy/copy_nonoverlapping fn's again Make copy/copy_nonoverlapping fn's again, rather than intrinsics. This a short-term change to address issue rust-lang#84297. It effectively reverts PRs rust-lang#81167 rust-lang#81238 (and part of rust-lang#82967), rust-lang#83091, and parts of rust-lang#79684.

rust-highfive assigned dtolnay Jan 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2021

This comment has been minimized.

Sign in to view

usbalbin force-pushed the const_write branch from 45f0a89 to 72a232d Compare January 18, 2021 20:11

usbalbin commented Jan 18, 2021

View reviewed changes

library/core/src/ptr/mod.rs Outdated Show resolved Hide resolved

usbalbin commented Jan 18, 2021

View reviewed changes

library/core/src/ptr/mod.rs Outdated Show resolved Hide resolved

usbalbin force-pushed the const_write branch 3 times, most recently from 5b9824c to b88cb40 Compare January 18, 2021 22:00

This comment has been minimized.

Sign in to view

usbalbin force-pushed the const_write branch from c265e66 to 6d2f079 Compare January 19, 2021 02:50

This comment has been minimized.

Sign in to view

oli-obk unassigned dtolnay Jan 19, 2021

RalfJung reviewed Jan 19, 2021

View reviewed changes

library/core/src/ptr/mod.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

usbalbin force-pushed the const_write branch from 2258270 to b05f073 Compare January 19, 2021 19:04

c410-f3r mentioned this pull request Jan 19, 2021

[RFC] A new stack-based vector rust-lang/rfcs#2990

Closed

This comment has been minimized.

Sign in to view

usbalbin changed the title ~~Experiment - Make ptr::write const~~ Make ptr::write const Feb 5, 2021

This comment has been minimized.

Sign in to view

usbalbin force-pushed the const_write branch from a1fef1d to 3756028 Compare February 23, 2021 12:41

This comment has been minimized.

Sign in to view

oli-obk marked this pull request as ready for review February 23, 2021 16:27

usbalbin force-pushed the const_write branch from 9fd1ea7 to b0a7469 Compare February 23, 2021 16:35

RalfJung reviewed Feb 23, 2021

View reviewed changes

library/core/src/ptr/mod.rs Outdated Show resolved Hide resolved

RalfJung reviewed Feb 23, 2021

View reviewed changes

library/core/src/ptr/mod.rs Outdated Show resolved Hide resolved

Constify ptr::write and the write[_unaligned] methods on *mut T

89c7610

Constify intrinsics::forget

usbalbin force-pushed the const_write branch from b0a7469 to 89c7610 Compare February 23, 2021 17:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2021

Dylan-DPC-zz mentioned this pull request Feb 24, 2021

Rollup of 13 pull requests #82481

Closed

Dylan-DPC-zz mentioned this pull request Feb 25, 2021

Rollup of 16 pull requests #82517

Merged

bors merged commit 4b9c213 into rust-lang:master Feb 25, 2021

rustbot added this to the 1.52.0 milestone Feb 25, 2021

jplatte mentioned this pull request Mar 4, 2021

Data to add jplatte/caniuse.rs#16

Open

65 tasks

pnkfelix mentioned this pull request Jun 4, 2021

Make copy/copy_nonoverlapping fn's again #86003

Merged

ChrisDenton mentioned this pull request Jun 12, 2021

feature(const_ptr_write) is broken #86236

Closed

usbalbin mentioned this pull request Jun 14, 2021

Tracking Issue for const_ptr_write #86302

Closed

9 tasks

Uh oh!

Conversation

usbalbin commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jan 18, 2021

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

oli-obk commented Jan 19, 2021

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

usbalbin commented Feb 5, 2021

Uh oh!

This comment has been minimized.

usbalbin commented Feb 23, 2021

Uh oh!

This comment has been minimized.

RalfJung commented Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Feb 23, 2021

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Feb 24, 2021

Uh oh!

bors commented Feb 24, 2021

Uh oh!

usbalbin commented Feb 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

usbalbin commented Jan 18, 2021 •

edited

Loading

RalfJung commented Feb 23, 2021 •

edited

Loading