Refactor alloc/rc.rs into separate files

[yoshuawuyts]

Similar to #81269, this patch splits alloc/rc.rs into a submodule, tracking Rc and Weak in separate files making it easier to work on the individual types. Thanks!

Changes

• alloc::rc::Rc now lives in libraries/alloc/rc/rc.rs
• alloc::rc::Weak now lives in libraries/alloc/rc/weak.rs
• the majority of tests now live in alloc/tests/arc.rs
• one test which tests internals is in alloc/rc/rc.rs

r? @KodrAus @Mark-Simulacrum

[yoshuawuyts]

Fixed the merge conflict.

If CI passes, I would appreciate a review on this. This is a rather large refactor, and keeping it up to date week over week can be challenging.

[KodrAus]

Thanks for working on this @yoshuawuyts!

It looks like we've got a tidy lint failure, but I'll run through the diff in the meantime.

[KodrAus]

I manually mapped the diff back into the original rc.rs file and everything looks like it found its way into the new structure. I'll check out the tidy error and try get this through.

[KodrAus]

@bors r+

Optimistically. I'll check back in here if the build fails.

[bors]

📌 Commit 25c79f6e1633b4f5c32897e738cf59d9bffe3383 has been approved by KodrAus

[Mark-Simulacrum]

@bors rollup=never

These are frequently perf sensitive, unfortunately.

[bors]

⌛ Testing commit 25c79f6e1633b4f5c32897e738cf59d9bffe3383 with merge ffd1d01aba565e49ff9fea164d09310258468286...

[bors]

💔 Test failed - checks-actions

[KodrAus]

@bors try

[bors]

⌛ Trying commit f827af42634db2e00b37c6f5f26f662c14787b76 with merge 21fef35f54cf849c200204fae70a193547de1b93...

[bors]

💔 Test failed - checks-actions

[bors]

☔ The latest upstream changes (presumably #82053) made this pull request unmergeable. Please resolve the merge conflicts.

[KodrAus]

It looks like we've run into a few more merge conflicts. Sorry for the pain here @yoshuawuyts! Maybe what we could do here is either:

• Pick a time when we're both active and try shepherd this through together quickly
• Try splitting it up in phases, where each file gets its own PR to reduce the chance of conflicts appearing

[yoshuawuyts]

@KodrAus picking a time would have my preference. Let's chat on Zulip?

[KodrAus]

@bors r+

[bors]

📌 Commit 65bbb3d has been approved by KodrAus

[bors]

⌛ Testing commit 65bbb3d with merge 661c87708b69bd03ed3a1a31adbcba2c9032fbb4...

[rust-log-analyzer]

The job dist-various-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] build_script_build test:false 0.567
   Compiling rustc-std-workspace-core v1.99.0 (/checkout/library/rustc-std-workspace-core)
[RUSTC-TIMING] rustc_std_workspace_core test:false 0.025
   Compiling alloc v0.0.0 (/checkout/library/alloc)
error: unused imports: `MarkerEq`, `is_dangling`
   --> library/alloc/src/rc/mod.rs:257:24
    |
257 | pub(crate) use utils::{is_dangling, MarkerEq};
    |                        ^^^^^^^^^^^  ^^^^^^^^
    |
    = note: `-D unused-imports` implied by `-D warnings`
[RUSTC-TIMING] compiler_builtins test:false 1.781
error: aborting due to previous error

[RUSTC-TIMING] alloc test:false 1.274
[RUSTC-TIMING] alloc test:false 1.274
error: could not compile `alloc`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] core test:false 16.926
error: build failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "thumbv6m-none-eabi" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "-p" "alloc" "--manifest-path" "/checkout/library/alloc/Cargo.toml" "--features" "compiler-builtins-mem compiler-builtins-c" "--message-format" "json-render-diagnostics"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --host= --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
Build completed unsuccessfully in 0:14:10

[bors]

💔 Test failed - checks-actions

[Dylan-DPC-zz]

@bors r-

[crlf0710]

@yoshuawuyts Ping from triage, it seems CI is still failing here.

[bors]

☔ The latest upstream changes (presumably #83726) made this pull request unmergeable. Please resolve the merge conflicts.

[yoshuawuyts]

More patches have been merged since. I'm going to shelve this for now (: