Restore linking to itself in implementors section of trait page

[LeSeulArtichaut]

Reverts #32558 as proposed in this Zulip discussion
r? @jyn514 cc @camelid

[jyn514]

cc @sanxiyn, @nodakai, @steveklabnik

The reason I think it makes sense to revert is because the change was only made for traits, which makes the documentation look inconsistent - some pages have links to themselves and others don't. I would be okay with a general feature which never adds a link if it goes to the current page, but it would be quite a bit more work and I don't think special-casing traits is the right approach in the meantime.

@LeSeulArtichaut the implementation looks fine, but I'd prefer to hear back from one of the three people I pinged before merging this.

[steveklabnik]

I am fine with whatever the rustdoc team feels is appropriate here.

[bors]

☔ The latest upstream changes (presumably #80987) made this pull request unmergeable. Please resolve the merge conflicts.

[camelid]

Steve said they're OK with whatever we (T-rustdoc) think. So: @rustbot label: -I-needs-decision

Is an FCP necessary here? I would think not, but wanted to check.

[jyn514]

I don't think this needs an FCP, no, this is just fixing an inconsistency rather than adding a feature.

[jyn514]

Is this ever called with use_absolute: true? If not, can you remove the parameter?

[LeSeulArtichaut]

It's used here:

rust/src/librustdoc/html/render/mod.rs

Line 3773 in 1daddb4

write!(w, "{}", i.inner_impl().print(cx.cache(), use_absolute));

Where AFAICT use_absolute can be true from

rust/src/librustdoc/html/render/mod.rs

Lines 2476 to 2483 in 1daddb4

	let use_absolute = match implementor.inner_impl().for_ {
	clean::ResolvedPath { ref path, is_generic: false, .. }
	| clean::BorrowedRef {
	type_: box clean::ResolvedPath { ref path, is_generic: false, .. },
	..
	} => implementor_dups[&path.last()].1,
	_ => false,
	};

[jyn514]

@bors r+

[bors]

📌 Commit 1daddb4 has been approved by jyn514

[bors]

⌛ Testing commit 1daddb4 with merge 921ec4b...

[bors]

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 921ec4b to master...