BTreeMap: bundle the duplication of node references in navigate.rs#81332
Closed
ssomers wants to merge 1 commit intorust-lang:masterfrom
ssomers:btree_drainy_refactor_6
Closed
BTreeMap: bundle the duplication of node references in navigate.rs#81332ssomers wants to merge 1 commit intorust-lang:masterfrom ssomers:btree_drainy_refactor_6
ssomers wants to merge 1 commit intorust-lang:masterfrom
ssomers:btree_drainy_refactor_6
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
This does not feel clearer to me personally - I'd have to look at what fork does pretty much everytime I saw it, and the existing code is not really longer or more confusing to my eyes. (If I'm not convinced by any argument you may make, probably will close this PR) |
Mark-Simulacrum
added
S-waiting-on-author
Contributor
Author
|
I wasn't convinced by this one either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largely independent of #81094.
r? @Mark-Simulacrum