[libtest] Run the test synchronously when hitting thread limit · Pull Request #81546 · rust-lang/rust

ghost · 2021-01-30T06:35:20Z

libtest currently panics if it hits the thread limit. This often results in spurious test failures (thread 'main' panicked at 'called Result::unwrap() on an Err value: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }' ... error: test failed, to rerun pass '--lib'). This PR makes it continue to run the test synchronously if it runs out of threads.

Closes #78165.

@rustbot label: A-libtest T-libs

rust-highfive · 2021-01-30T06:35:23Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

library/test/src/lib.rs

library/test/tests/hit-thread-limit.rs

library/test/src/lib.rs

library/test/tests/hit-thread-limit.rs

ghost · 2021-02-12T12:28:08Z

(All done 🚀)
@rustbot label -S-waiting-on-author S-waiting-on-review

Mark-Simulacrum · 2021-02-13T15:26:57Z

r=me with commits squashed into one

ghost · 2021-02-13T16:11:45Z

Squashed.
@rustbot label -S-waiting-on-author S-waiting-on-review

Mark-Simulacrum · 2021-02-13T18:30:55Z

@bors r+ rollup=iffy

bors · 2021-02-13T18:30:56Z

📌 Commit 114d48c95006f1f780044c22d982c03a4d7063e0 has been approved by Mark-Simulacrum

bors · 2021-02-17T03:32:03Z

⌛ Testing commit 114d48c95006f1f780044c22d982c03a4d7063e0 with merge 7c95091268bb409d5ed86b56ed29d850da16417b...

bors · 2021-02-17T04:07:32Z

💔 Test failed - checks-actions

src/test/run-make/libtest-thread-limit/Makefile

Mark-Simulacrum · 2021-02-17T13:44:42Z

@bors r+

bors · 2021-02-17T13:44:43Z

📌 Commit 43aed74 has been approved by Mark-Simulacrum

… r=Mark-Simulacrum [libtest] Run the test synchronously when hitting thread limit libtest currently panics if it hits the thread limit. This often results in spurious test failures (<code>thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }'</code> ... `error: test failed, to rerun pass '--lib'`). This PR makes it continue to run the test synchronously if it runs out of threads. Closes rust-lang#78165. `@rustbot` label: A-libtest T-libs

Rollup of 10 pull requests Successful merges: - rust-lang#81546 ([libtest] Run the test synchronously when hitting thread limit) - rust-lang#82066 (Ensure valid TraitRefs are created for GATs) - rust-lang#82112 (const_generics: Dont evaluate array length const when handling yet another error ) - rust-lang#82194 (In some limited cases, suggest `where` bounds for non-type params) - rust-lang#82215 (Replace if-let and while-let with `if let` and `while let`) - rust-lang#82218 (Make sure pdbs are copied along with exe and dlls when bootstrapping) - rust-lang#82236 (avoid converting types into themselves (clippy::useless_conversion)) - rust-lang#82246 (Add long explanation for E0549) - rust-lang#82248 (Optimize counting digits in line numbers during error reporting) - rust-lang#82256 (Print -Ztime-passes (and misc stats/logs) on stderr, not stdout.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2021-10-22T14:59:06Z

library/test/src/lib.rs

+                Err(e) if e.kind() == io::ErrorKind::WouldBlock => {
+                    // `ErrorKind::WouldBlock` means hitting the thread limit on some
+                    // platforms, so run the test synchronously here instead.
+                    Arc::get_mut(&mut runtest).unwrap().get_mut().unwrap().take().unwrap()();


So we know at this point that runtest2 has been dropped? That is subtle.

rust-highfive assigned Mark-Simulacrum Jan 30, 2021

rustbot added A-libtest Area: `#[test]` / the `test` library T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 30, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2021

ghost commented Jan 30, 2021

View reviewed changes

library/test/src/lib.rs Outdated Show resolved Hide resolved

library/test/tests/hit-thread-limit.rs Outdated Show resolved Hide resolved

ghost mentioned this pull request Jan 30, 2021

libtest: Don't panic if unable to spawn thread #78165

Closed

camelid mentioned this pull request Jan 30, 2021

Poor formatting of long method call chain with use_small_heuristics="Max" rust-lang/rustfmt#4678

Closed

Mark-Simulacrum reviewed Feb 12, 2021

View reviewed changes

library/test/src/lib.rs Outdated Show resolved Hide resolved

Mark-Simulacrum reviewed Feb 12, 2021

View reviewed changes

library/test/tests/hit-thread-limit.rs Outdated Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2021

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2021

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2021

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2021

This comment has been minimized.

Sign in to view

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 17, 2021

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2021

Mark-Simulacrum reviewed Feb 17, 2021

View reviewed changes

src/test/run-make/libtest-thread-limit/Makefile Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2021

Mark-Simulacrum reviewed Feb 17, 2021

View reviewed changes

src/test/run-make/libtest-thread-limit/Makefile Outdated Show resolved Hide resolved

[libtest] Run the test synchronously when hitting thread limit

43aed74

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2021

This was referenced Feb 18, 2021

Rollup of 10 pull requests #82262

Closed

Rollup of 10 pull requests #82263

Merged

bors merged commit 55ab2e3 into rust-lang:master Feb 18, 2021

rustbot added this to the 1.52.0 milestone Feb 18, 2021

ghost deleted the libtest-run-out-of-threads branch February 27, 2021 10:26

jplatte mentioned this pull request Oct 22, 2021

rustc panics when it can't spawn a thread #72482

Closed

RalfJung reviewed Oct 22, 2021

View reviewed changes

jieyouxu mentioned this pull request Aug 2, 2024

Migrate libtest-thread-limit run-make test to rmake #128507

Merged

Uh oh!

Conversation

ghost commented Jan 30, 2021

Uh oh!

rust-highfive commented Jan 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Feb 12, 2021

Uh oh!

Mark-Simulacrum commented Feb 13, 2021

Uh oh!

ghost commented Feb 13, 2021

Uh oh!

Mark-Simulacrum commented Feb 13, 2021

Uh oh!

bors commented Feb 13, 2021

Uh oh!

bors commented Feb 17, 2021

Uh oh!

This comment has been minimized.

bors commented Feb 17, 2021

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum commented Feb 17, 2021

Uh oh!

bors commented Feb 17, 2021

Uh oh!

RalfJung Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants