Stabilize `peekable_peek_mut` by lukaslueg · Pull Request #81938 · rust-lang/rust

lukaslueg · 2021-02-09T21:20:59Z

Resolves #78302. Also adds some documentation on std::iter::Iterator::peekable() regarding the new method.

The feature was added in #77491 in Nov' 20, which is recently, but the feature seems reasonably small. Never did a stabilization-pr, excuse my ignorance if there is a protocol I'm not aware of.

rust-highfive · 2021-02-09T21:21:02Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

bors · 2021-02-13T06:10:00Z

☔ The latest upstream changes (presumably #82045) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2021-02-13T22:15:48Z

r? @KodrAus

bors · 2021-02-18T07:51:02Z

☔ The latest upstream changes (presumably #81172) made this pull request unmergeable. Please resolve the merge conflicts.

KodrAus

Thanks for the PR @lukaslueg! 🙇

I hope you don't mind I've just pushed a couple commits to your branch to fix a merge conflict and update the stable version to 1.52.0.

Would you be happy to squash these commits down?

r=me after that

library/core/src/iter/traits/iterator.rs

lukaslueg · 2021-02-21T11:55:35Z

Squashed it all

lukaslueg · 2021-02-25T22:37:10Z

ping @KodrAus

library/core/src/iter/traits/iterator.rs

JohnTitor · 2021-03-17T17:20:19Z

Thanks!
So, since @KodrAus said r=me before and the next release will happen soon, I'm going to approve not to slip down.
@bors r=KodrAus,JohnTitor

bors · 2021-03-17T17:20:20Z

📌 Commit 8af15db has been approved by KodrAus,JohnTitor

…JohnTitor Stabilize `peekable_peek_mut` Resolves rust-lang#78302. Also adds some documentation on `std::iter::Iterator::peekable()` regarding the new method. The feature was added in rust-lang#77491 in Nov' 20, which is recently, but the feature seems reasonably small. Never did a stabilization-pr, excuse my ignorance if there is a protocol I'm not aware of.

lukaslueg · 2021-03-17T22:30:57Z

Isn't there usually a vote on stabilizing things, especially since this indirectly affects Iterator?

JohnTitor · 2021-03-17T22:55:38Z

Isn't there usually a vote on stabilizing things, especially since this indirectly affects Iterator?

Hm, I thought they meant we didn't require it, @KodrAus is it wrong?

Mark-Simulacrum · 2021-03-17T22:56:31Z

@bors r- I'd rather we don't accidentally stabilize, and I think an FCP seems appropriate here.

Resolves rust-lang#78302 Update peekable.rs Update library/core/src/iter/traits/iterator.rs Co-authored-by: Ashley Mannix <kodraus@hey.com>

lukaslueg · 2021-03-26T16:44:45Z

Rebased due to #83349

rfcbot · 2021-03-27T11:52:39Z

🔔 This is now entering its final comment period, as per the review above. 🔔

library/core/src/iter/adapters/peekable.rs

rfcbot · 2021-04-06T11:52:43Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>

Amanieu · 2021-04-07T09:34:12Z

It seems that the review suggestions by @JohnTitor didn't actually get applied?

Co-authored-by: Yuki Okushi <jtitor@2k36.org>

lukaslueg · 2021-04-07T16:03:44Z

It seems that the review suggestions by @JohnTitor didn't actually get applied?

👀 Thanks for spotting this. I have no idea why these commits slipped through, maybe during rebase.

Amanieu · 2021-04-08T16:19:00Z

@bors r+ rollup

bors · 2021-04-08T16:19:02Z

📌 Commit cfe43f9 has been approved by Amanieu

Stabilize `peekable_peek_mut` Resolves rust-lang#78302. Also adds some documentation on `std::iter::Iterator::peekable()` regarding the new method. The feature was added in rust-lang#77491 in Nov' 20, which is recently, but the feature seems reasonably small. Never did a stabilization-pr, excuse my ignorance if there is a protocol I'm not aware of.

Rollup of 6 pull requests Successful merges: - rust-lang#80733 (Improve links in inline code in `core::pin`.) - rust-lang#81764 (Stabilize `rustdoc::bare_urls` lint) - rust-lang#81938 (Stabilize `peekable_peek_mut`) - rust-lang#83980 (Fix outdated crate names in compiler docs) - rust-lang#83992 (Merge idents when generating source content) - rust-lang#84001 (Update Clippy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned Mark-Simulacrum Feb 9, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2021

jonas-schievink added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Feb 9, 2021

rust-highfive assigned KodrAus and unassigned Mark-Simulacrum Feb 13, 2021

lukaslueg force-pushed the stab_peek_mut branch from 00e117d to dd3db70 Compare February 13, 2021 22:34

KodrAus reviewed Feb 21, 2021

View reviewed changes

library/core/src/iter/traits/iterator.rs Outdated Show resolved Hide resolved

lukaslueg force-pushed the stab_peek_mut branch from 2acb30d to e292e6e Compare February 21, 2021 11:51

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2021

JohnTitor reviewed Mar 17, 2021

View reviewed changes

library/core/src/iter/traits/iterator.rs Outdated Show resolved Hide resolved

library/core/src/iter/traits/iterator.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2021

Dylan-DPC-zz mentioned this pull request Mar 17, 2021

Rollup of 9 pull requests #83240

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2021

Stabilize peekable_peek_mut

abcbe54

Resolves rust-lang#78302 Update peekable.rs Update library/core/src/iter/traits/iterator.rs Co-authored-by: Ashley Mannix <kodraus@hey.com>

lukaslueg force-pushed the stab_peek_mut branch from 8af15db to abcbe54 Compare March 26, 2021 16:43

m-ou-se mentioned this pull request Mar 27, 2021

Tracking issue for std::iter::Peekable::peek_mut #78302

Closed

2 tasks

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 27, 2021

pthariensflame suggested changes Apr 1, 2021

View reviewed changes

library/core/src/iter/adapters/peekable.rs Outdated Show resolved Hide resolved

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 6, 2021

lukaslueg and others added 2 commits April 6, 2021 18:16

Update library/core/src/iter/adapters/peekable.rs

7f32fda

Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>

Merge branch 'master' into stab_peek_mut

72796a7

lukaslueg and others added 2 commits April 7, 2021 18:02

Update library/core/src/iter/traits/iterator.rs

4c850f3

Co-authored-by: Yuki Okushi <jtitor@2k36.org>

Update library/core/src/iter/traits/iterator.rs

cfe43f9

Co-authored-by: Yuki Okushi <jtitor@2k36.org>

apiraino removed the to-announce Announce this issue on triage meeting label Apr 8, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2021

This was referenced Apr 8, 2021

Rollup of 5 pull requests #84005

Closed

Rollup of 6 pull requests #84008

Merged

bors merged commit 461297e into rust-lang:master Apr 8, 2021

rustbot added this to the 1.53.0 milestone Apr 8, 2021

lukaslueg deleted the stab_peek_mut branch April 9, 2021 08:54

Uh oh!

Conversation

lukaslueg commented Feb 9, 2021

Uh oh!

rust-highfive commented Feb 9, 2021

Uh oh!

bors commented Feb 13, 2021

Uh oh!

Mark-Simulacrum commented Feb 13, 2021

Uh oh!

bors commented Feb 18, 2021

Uh oh!

KodrAus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lukaslueg commented Feb 21, 2021

Uh oh!

lukaslueg commented Feb 25, 2021

Uh oh!

Uh oh!

Uh oh!

JohnTitor commented Mar 17, 2021

Uh oh!

bors commented Mar 17, 2021

Uh oh!

lukaslueg commented Mar 17, 2021

Uh oh!

JohnTitor commented Mar 17, 2021

Uh oh!

Mark-Simulacrum commented Mar 17, 2021

Uh oh!

lukaslueg commented Mar 26, 2021

Uh oh!

rfcbot commented Mar 27, 2021

Uh oh!

Uh oh!

rfcbot commented Apr 6, 2021

Uh oh!

Amanieu commented Apr 7, 2021

Uh oh!

lukaslueg commented Apr 7, 2021

Uh oh!

Amanieu commented Apr 8, 2021

Uh oh!

bors commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants