Only keep one dep-graph in memory#82345
Conversation
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit 16d80aed4c981fa64a23bdd86665e6d424d00e31 with merge 3e82a8e64b10e2ad24021e1bd97e5374fbfa9757... |
|
☔ The latest upstream changes (presumably #70951) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☀️ Try build successful - checks-actions |
|
Queued 3e82a8e64b10e2ad24021e1bd97e5374fbfa9757 with parent e7c23ab, future comparison URL. |
|
Finished benchmarking try commit (3e82a8e64b10e2ad24021e1bd97e5374fbfa9757): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Significant regressions of up to 6%. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit 10844018aa5118c4407b8c512ac2c55e03ea0a47 with merge 7d3e46cdccabc8f3cfc056edc05a570756da768c... |
|
☀️ Try build successful - checks-actions |
|
Queued 7d3e46cdccabc8f3cfc056edc05a570756da768c with parent a15f484, future comparison URL. |
|
Finished benchmarking try commit (7d3e46cdccabc8f3cfc056edc05a570756da768c): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
@bors try @rust-timer queue |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit 91734f1 with merge de903c91da2158c76094697c62f036b7a3324155... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
With atomics |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit 0c7de43 with merge cfb73662247a17bcf07f635d74389d1aeb2df26c... |
|
☀️ Try build successful - checks-actions |
|
Queued cfb73662247a17bcf07f635d74389d1aeb2df26c with parent b36f770, future comparison URL. |
|
Finished benchmarking try commit (cfb73662247a17bcf07f635d74389d1aeb2df26c): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Closed in favour of #82780. |
This is a re-implementation from scratch of the dep-graph storage.
Instead of keeping the deserialized dep-graph immutable in memory,
this implementation modifies it in-place, and appends new dep-nodes to it.
The graph is cleaned-up at saving time, where all the nodes are renumbered to remove stale nodes.
r? @ghost