rustdoc: Get TyCtxt from self instead of passing as argument in AutoTraitFinder#82597
rustdoc: Get TyCtxt from self instead of passing as argument in AutoTraitFinder#82597bors merged 1 commit intorust-lang:masterfrom noslaver:fix-82137
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Just a tip, using a descriptive PR title and commit message is helpful. When reading the git log, seeing something like "fix issue #82137" doesn't really have any context, and seeing a PR title also has similar issues. It can be helpful when commit messages stand on their own, where they explain what the change is and why it is being made. Git has some guidelines for commit messages. |
GuillaumeGomez
added
C-cleanup
|
Looks good to me. Since it also changes some code in the compiler, I'll wait for someone from @rust-lang/compiler to approve it as well. |
|
r=me with ehuss' comment addressed. |
Updated git comment, should I update the PR title as well? |
|
Yes please. |
noslaver
changed the title
|
☔ The latest upstream changes (presumably #81349) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
changed the title
|
There's now a merge conflict. You will have to checkout a recent master and rebase on top of it. |
This comment has been minimized.
This comment has been minimized.
|
@bors r=nagisa |
|
📌 Commit 854fffd has been approved by |
bors
added
S-waiting-on-bors
Rollup of 10 pull requests Successful merges: - rust-lang#80189 (Convert primitives in the standard library to intra-doc links) - rust-lang#80874 (Update intra-doc link documentation to match the implementation) - rust-lang#82376 (Add option to enable MIR inlining independently of mir-opt-level) - rust-lang#82516 (Add incomplete feature gate for inherent associate types.) - rust-lang#82579 (Fix turbofish recovery with multiple generic args) - rust-lang#82593 (Teach rustdoc how to display WASI.) - rust-lang#82597 (Get TyCtxt from self instead of passing as argument in AutoTraitFinder) - rust-lang#82627 (Erase late bound regions to avoid ICE) - rust-lang#82661 (:arrow_up: rust-analyzer) - rust-lang#82691 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
jyn514
changed the title
11 participants
First contribution 🦀, let me know if anything is amiss.
Fix #82137.