Conversation
camelid
added
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
force-pushed
the
everybody_loops-docs
branch
from
f371fc2 to
bd203df
Compare
compiler/rustc_interface/src/util.rs
Outdated
There was a problem hiding this comment.
Do you want to add support here? I think it would be as simple as removing within_static_or_const and https://github.com/rust-lang/rust/blob/bd203dfe0a70bd4c5fe3927b16ed75d3d0e13b2c/compiler/rustc_interface/src/util.rs#L865.
There was a problem hiding this comment.
Probably makes sense to do that in a separate PR since it would require signoff on the change.
compiler/rustc_interface/src/util.rs
Outdated
There was a problem hiding this comment.
Does this need to be mentioned? This seems only of historical interest, and you can find it easily with git or a google search.
There was a problem hiding this comment.
This seems only of historical interest, and you can find it easily with git or a google search.
I wanted to make it clear that it's only used for debugging. Someone reading the code might not think of or might not want to spend the time of doing a search.
There was a problem hiding this comment.
Ok, then I would say something like "This is used for the -Z unpretty=everybody_loops debugging pass"`. I don't think you need to mention rustdoc.
There was a problem hiding this comment.
Personally, I would still prefer to mention rustdoc, but it doesn't matter that much so I removed the sentence about rustdoc :)
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
everybody_loops-docs
branch
from
bd203df to
9f18254
Compare
|
r? @jyn514 |
jyn514
added
S-waiting-on-author
camelid
force-pushed
the
everybody_loops-docs
branch
from
9f18254 to
1814923
Compare
camelid
added
S-waiting-on-review
camelid
force-pushed
the
everybody_loops-docs
branch
from
1814923 to
8164a74
Compare
|
@bors r+ cc @pnkfelix, you might be interested in adding support for |
|
📌 Commit 8164a74 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 10 pull requests Successful merges: - rust-lang#81465 (Add documentation about formatting `Duration` values) - rust-lang#82121 (Implement Extend and FromIterator for OsString) - rust-lang#82617 (Document `everybody_loops`) - rust-lang#82789 (Get with field index from pattern slice instead of directly indexing) - rust-lang#82798 (Rename `rustdoc` to `rustdoc::all`) - rust-lang#82804 (std: Fix a bug on the wasm32-wasi target opening files) - rust-lang#82943 (Demonstrate best practice for feeding stdin of a child processes) - rust-lang#83066 (Add `reverse` search alias for Iterator::rev()) - rust-lang#83070 (Update cargo) - rust-lang#83081 (Fix panic message of `assert_failed_inner`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
6 participants
cc @jyn514