Report missing cases of `bare_trait_objects` by petrochenkov · Pull Request #82868 · rust-lang/rust

petrochenkov · 2021-03-07T18:04:08Z

rust-highfive · 2021-03-07T18:04:11Z

(rust-highfive has picked a reviewer for you, use r? to override)

src/test/ui/unspecified-self-in-trait-ref.stderr

estebank · 2021-03-10T02:28:36Z

It should probably be reported later instead, only if the path ends up being successfully resolved.

maybe_lint_bare_trait is already using buffered_lints, but they are still emitted after parse. We could potentially delay them further and prune the list during resolve as appropriate.

estebank · 2021-03-10T02:30:03Z

Beyond the concerns about now incorrect suggestions and the increased number of warnings for code in the wild, r=me. If you land this without addressing the two comments, please file a follow up ticket so we don't forget to fix them eventually.

petrochenkov · 2021-03-12T21:33:53Z

We could potentially delay them further and prune the list during resolve as appropriate.

It has to be delayed until type checking when type-relative associated items are resolved.
I'll try to look at this tomorrow.

petrochenkov · 2021-03-13T18:58:46Z

Blocked on #83092.

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? `@estebank`

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? ``@estebank``

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? ```@estebank```

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? ``@estebank``

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? ```@estebank```

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? ````@estebank````

petrochenkov · 2021-03-17T23:19:39Z

Updated.

estebank · 2021-03-17T23:28:13Z

r=me after fixing clippy

petrochenkov · 2021-03-18T00:03:38Z

@bors r=estebank

bors · 2021-03-18T00:03:39Z

📌 Commit b48530b has been approved by estebank

bors · 2021-03-18T05:27:30Z

⌛ Testing commit b48530b with merge 2aafe45...

bors · 2021-03-18T08:17:59Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2aafe45 to master...

More precise spans for HIR paths `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path. This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span. This is a pre-requisite for rust-lang/rust#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans). r? ````@estebank````

rust-highfive assigned estebank Mar 7, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2021

petrochenkov mentioned this pull request Mar 7, 2021

Lint bare_trait_objects doesn't warn on traits used as types in paths #65371

Closed

estebank reviewed Mar 10, 2021

View reviewed changes

src/test/ui/unspecified-self-in-trait-ref.stderr Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2021

petrochenkov mentioned this pull request Mar 13, 2021

More precise spans for HIR paths #83092

Merged

petrochenkov force-pushed the bto branch from 7056cb3 to c6c9f1d Compare March 13, 2021 18:59

petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2021

This comment has been minimized.

Sign in to view

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 17, 2021

petrochenkov force-pushed the bto branch from c6c9f1d to 8f5dacc Compare March 17, 2021 23:16

Fix use of bare trait objects everywhere

dac96d4

petrochenkov force-pushed the bto branch from 8f5dacc to 42393cd Compare March 17, 2021 23:19

petrochenkov removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 17, 2021

petrochenkov added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2021

This comment has been minimized.

Sign in to view

petrochenkov added 2 commits March 18, 2021 03:02

hir: Preserve used syntax in TyKind::TraitObject

38ed36b

Report missing cases of bare_trait_objects

b48530b

petrochenkov force-pushed the bto branch from 42393cd to b48530b Compare March 18, 2021 00:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2021

bors merged commit 2aafe45 into rust-lang:master Mar 18, 2021

rustbot added this to the 1.52.0 milestone Mar 18, 2021

bors mentioned this pull request Mar 18, 2021

Refactor rustc_resolve::late::lifetimes to resolve per-item #82743

Merged

Swatinem mentioned this pull request Mar 22, 2021

ref(clippy): Use <dyn Fail> for trait getsentry/symbolicator#407

Merged

memoryruins mentioned this pull request Mar 23, 2021

Incorrect warning about trait object use when accessing trait method via subtrait #83395

Closed

dtolnay mentioned this pull request May 24, 2021

Resolve bare_trait_objects lints dtolnay/erased-serde#42

Merged

petrochenkov deleted the bto branch February 22, 2025 18:31

Uh oh!

Conversation

petrochenkov commented Mar 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 7, 2021

Uh oh!

Uh oh!

estebank commented Mar 10, 2021

Uh oh!

estebank commented Mar 10, 2021

Uh oh!

petrochenkov commented Mar 12, 2021

Uh oh!

petrochenkov commented Mar 13, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Mar 17, 2021

Uh oh!

This comment has been minimized.

estebank commented Mar 17, 2021

Uh oh!

petrochenkov commented Mar 18, 2021

Uh oh!

bors commented Mar 18, 2021

Uh oh!

bors commented Mar 18, 2021

Uh oh!

bors commented Mar 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

petrochenkov commented Mar 7, 2021 •

edited

Loading