Remove unused DiagnosticBuilder::sub function#83161
Closed
jyn514 wants to merge 1 commit intorust-lang:masterfrom
Closed
Remove unused DiagnosticBuilder::sub function#83161jyn514 wants to merge 1 commit intorust-lang:masterfrom
DiagnosticBuilder::sub function#83161jyn514 wants to merge 1 commit intorust-lang:masterfrom
Conversation
`Diagnostic::sub` is only ever used directly; it doesn't need to be included in the builder.
jyn514
added
C-cleanup
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 29, 2021
Remove (lots of) dead code Builds on - [ ] rust-lang#83161 - [x] rust-lang#83230 - [x] rust-lang#83197. Found with https://github.com/est31/warnalyzer. See rust-lang#77739 for a similar change in the past. Dubious changes: - Maybe some of the dead code in rustc_data_structures should be kept, in case someone wants to use it in the future? TODO: - [ ] check if any of the comments on the deleted code should be kept. - [x] update the compiler documentation; right now it fails to build - [x] finish moving `cfg(test)` changes into rust-lang#83197 cc `@est31`
bstrie
added
S-waiting-on-review
Member
Author
|
Merged as part of #83185. |
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
Remove (lots of) dead code Builds on - [ ] rust-lang/rust#83161 - [x] rust-lang/rust#83230 - [x] rust-lang/rust#83197. Found with https://github.com/est31/warnalyzer. See rust-lang/rust#77739 for a similar change in the past. Dubious changes: - Maybe some of the dead code in rustc_data_structures should be kept, in case someone wants to use it in the future? TODO: - [ ] check if any of the comments on the deleted code should be kept. - [x] update the compiler documentation; right now it fails to build - [x] finish moving `cfg(test)` changes into rust-lang/rust#83197 cc `@est31`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic::subis only ever used directly; it doesn't need to beincluded in the builder.