Simplify Command::spawn (no semantic change)#83170
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 30, 2021
Merged
Conversation
Contributor
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
Note that I based this PR on the branch from #83121 , to avoid a conflict. |
Member
|
CI not running? 🤔 |
Member
Author
|
I'd like to hold off on this one until #81825 gets in, since the two will likely conflict and that one has been waiting longer. I'll rebase this after that goes in. |
kennytm
added
S-blocked
Contributor
|
I also don't mind rebasing #81825 if you want to merge this first. |
Member
Author
|
@voidc I appreciate that, but this is a minor cleanup and I'm much more interested in the pidfd work. |
This minimizes the size of an unsafe block, and allows outdenting some complex code.
joshtriplett
force-pushed
the
spawn-cleanup
branch
from
ede3431 to
68dbdfb
Compare
Member
Author
|
Since #81825 seems to be blocked by an LLVM codegen issue, I'd like to go ahead and merge this. |
joshtriplett
added
S-waiting-on-review
Member
Author
Member
|
@bors r+ |
Collaborator
|
📌 Commit 68dbdfb has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minimizes the size of an unsafe block, and allows outdenting some
complex code.