Conversation
bjorn3
added
C-cleanup
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Rebased and added two extra commits. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
ff2af40cd7d4d3373bfdc247f2ad8847213aea51 should be functionally identical. Can it be a spurious error? |
crlf0710
added
S-waiting-on-review
cjgillot
left a comment
cjgillot
left a comment
There was a problem hiding this comment.
I left a few comments.
The CI will re-run with the additional commits. We will see then if the failure is spurious.
This is one step towards separating the linking code from codegen backends
This allows removing a confusing mem::replace in create_global_ctxt
This comment has been minimized.
This comment has been minimized.
|
CI passed. |
|
@bors r+ |
|
📌 Commit 163b480 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Performance triage indicates that this PR introduced a 1.7% regression when fully compiling I don't think any performance hit was expected. However, it also seems like this may be just noise. |
|
|
||
| pub(crate) untracked_crate: &'tcx hir::Crate<'tcx>, | ||
| pub(crate) definitions: &'tcx Definitions, | ||
| pub(crate) definitions: Definitions, |
There was a problem hiding this comment.
This is the only change I can think of that could caused the regression if it isn't just noise.
rustc_driver cleanup Best reviewed one commit at a time.
9 participants
Best reviewed one commit at a time.