Account for bad placeholder errors on consts/statics with trait objects#83739
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 21, 2021
Merged
Account for bad placeholder errors on consts/statics with trait objects#83739bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
crlf0710
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
|
looks good to me r? @Dylan-DPC @bors r+ rollup=never p=5 |
Collaborator
|
📌 Commit 79f0bcc64ab92684cb702f785e017544d67c22ae has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
@Dylan-DPC Hm, I don't think you're on the t-compiler, the release team can approve such a PR? And rollup status and priority don't seem suitable. |
|
uggh yeah wrong rollup option my bad |
|
@bors p=0 rollup=always |
|
normally it's fine for smaller trivial prs. But if you want someone from compiler team to look at it, let me know. Not an issue |
Member
Author
|
I'd ask a review from the compiler team to check if we don't have a diagnostic regression like #77431 (comment). |
bors
added
S-waiting-on-author
|
bah.. r? @estebank |
JohnTitor
added
S-waiting-on-review
bstrie
added
S-waiting-on-review
crlf0710
added
S-waiting-on-review
Member
Author
|
Friendly-ping @estebank, I guess you overlooked this? |
Contributor
|
@bors r+ @JohnTitor sorry, I've been out for the past few weeks. |
Collaborator
|
📌 Commit 052d77e has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
No problem, thanks for reviewing! |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 21, 2021
Account for bad placeholder errors on consts/statics with trait objects Fixes rust-lang#75889 r? `@estebank`
This was referenced Jun 21, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 21, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#83739 (Account for bad placeholder errors on consts/statics with trait objects) - rust-lang#85637 (document PartialEq, PartialOrd, Ord requirements more explicitly) - rust-lang#86152 (Lazify is_really_default condition in the RustdocGUI bootstrap step) - rust-lang#86156 (Fix a bug in the linkchecker) - rust-lang#86427 (Updated release note) - rust-lang#86452 (fix panic-safety in specialized Zip::next_back) - rust-lang#86484 (Do not set depth to 0 in fully_expand_fragment) - rust-lang#86491 (expand: Move some more derive logic to rustc_builtin_macros) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jun 21, 2021
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 13, 2022
…yn-obj, r=pnkfelix Harden bad placeholder checks on statics/consts Resubmission of rust-lang#89161 Fixes rust-lang#88643 In rust-lang#83739, I added a check for trait objects on statics/consts but it wasn't robust. `is_suggestable_infer_ty` fn does a more strict check and finds more bad placeholders. See rust-lang#89161 (comment) for the more detailed explanation. r? `@pnkfelix` as you're the reviewer of the previous PR
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#83739 (Account for bad placeholder errors on consts/statics with trait objects) - rust-lang#85637 (document PartialEq, PartialOrd, Ord requirements more explicitly) - rust-lang#86152 (Lazify is_really_default condition in the RustdocGUI bootstrap step) - rust-lang#86156 (Fix a bug in the linkchecker) - rust-lang#86427 (Updated release note) - rust-lang#86452 (fix panic-safety in specialized Zip::next_back) - rust-lang#86484 (Do not set depth to 0 in fully_expand_fragment) - rust-lang#86491 (expand: Move some more derive logic to rustc_builtin_macros) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75889
r? @estebank