Check for asm support in UI tests that require it#84099
Check for asm support in UI tests that require it#84099bors merged 1 commit intorust-lang:masterfrom
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
Hm, I wonder if we should avoid limiting to just x86_64 - regardless, I would like to see the comment annotated with why we're requiring that target/platform. r? @Amanieu |
|
We could add |
|
All the other asm tests do this. The main reason is that, although the specific functionality that is being tested is not arch-specific, we still need to pick an architecture that supports For simplicity we only run the tests on x86_64 to ensure they are tested by CI. The arch-specific parts of |
|
Makes sense, OK. I think comments or using something like needs-asm-support would be good, but not necessarily blockers. |
6fd4c7d to
5e87f97
Compare
|
@bors r+ |
|
📌 Commit 5e87f97 has been approved by |
Check for asm support in UI tests that require it Add `needs-asm-support` compiletest directive, and use it in asm tests that require asm support without relying on any architecture specific features. Closes rust-lang#84038.
5e87f97 to
da40e69
Compare
Add `needs-asm-support` compiletest directive, and use it in asm tests that require asm support without relying on any architecture specific features.
|
@bors r+ |
|
📌 Commit da40e69 has been approved by |
|
☀️ Test successful - checks-actions |
Add
needs-asm-supportcompiletest directive, and use it in asm teststhat require asm support without relying on any architecture specific
features.
Closes #84038.